darcs

Issue 510 There was an attempt to write an invalid pending! (1.0.9r1)

Title There was an attempt to write an invalid pending! (1.0.9r1)
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, jason, kowey, thorkilnaur, tommy
Assigned To
Topics

Created on 2007-08-06.18:15:11 by jason, last changed 2009-08-27.14:07:16 by admin.

Files
File name Uploaded Type Edit Remove
pending_buggy jason, 2007-08-06.18:15:10 text/plain
Messages
msg2013 (view) Author: jason Date: 2007-08-06.18:15:10
I have conflicting pending patches.  'darcs repair' and 'darcs check' 
don't report anything wrong, though.

Do you want to add a long comment? [yn]y
darcs: bug in darcs!
There was an attempt to write an invalid pending!
If possible, please send the contents of _darcs/patches/pending_buggy
along with a bug report.
Please report this to bugs@darcs.net
If possible include the output of 'darcs --exact-version'.

$ darcs --exact-version
darcs compiled on Nov 20 2006, at 14:33:22
# configured Mon Oct  9 15:12:44 EDT 2006
./configure --no-create --no-recursion

Context:

[TAG 1.0.9rc1
Tommy Pettersson <ptp@lysator.liu.se>**20061008175207]
Attachments
msg2015 (view) Author: kowey Date: 2007-08-06.18:56:20
Here seems to be the interesting part:

> move ./tmpls/locations.TMPL ./templates/locations.TMPL

... some intervening stuff on other files...

> rmfile ./tmpls/locations.TMPL

Note that here, it should be rmfile ./templates/locations.TMPL

Jason: any idea what sequence of steps led to this situation?

Thanks,
msg2016 (view) Author: jason Date: 2007-08-06.19:34:09
Not really - the sequence, if I could redo it would be pretty long.  I 
ended up moving the repo aside, re-getting it and then folding my 
changes back.  I don't remember doing a 'darcs mv' for that 
locations.TMPL file -- maybe I did?

There were a LOT of changes, so my guess is that something got corrupted 
a while ago.

Thanks!

Jason

Eric Y. Kow wrote:
> Here seems to be the interesting part:
> 
>> move ./tmpls/locations.TMPL ./templates/locations.TMPL
> 
> ... some intervening stuff on other files...
> 
>> rmfile ./tmpls/locations.TMPL
> 
> Note that here, it should be rmfile ./templates/locations.TMPL
> 
> Jason: any idea what sequence of steps led to this situation?
> 
> Thanks,
> 
>
msg2041 (view) Author: kowey Date: 2007-08-11.06:49:44
> Not really - the sequence, if I could redo it would be pretty long.

Ok. Thanks anyway.

> I ended up moving the repo aside, re-getting it and then folding my 
> changes back.

Glad to hear that you found a workaround.  I was going to suggest
editing the pending by hand.

> I don't remember doing a 'darcs mv' for that locations.TMPL file --
> maybe I did?

> There were a LOT of changes, so my guess is that something got corrupted 
> a while ago.

If you could make your repository available, it might be helpful (it may
let us ferret out the corruption), but I understand if that's not
possible.

Otherwise, without a reproducible example, I'm not sure we can do
anything with this.

Darcs: maybe a battery of quickcheck tests for pending?  Somehow
generate a sequence of moves, adds, removes, and trivial hunk changes to
make sure that the pending patch is always valid?
msg2057 (view) Author: droundy Date: 2007-08-13.16:45:37
On Sat, Aug 11, 2007 at 06:49:45AM -0000, Eric Kow wrote:
> Darcs: maybe a battery of quickcheck tests for pending?  Somehow
> generate a sequence of moves, adds, removes, and trivial hunk changes to
> make sure that the pending patch is always valid?

It's hard to say, without being able to reproduce this.  More tests in the
test suite are always a plus, but it's hard to figure out an efficient way
to generate test cases that are likely to reveal bugs!  :(
-- 
David Roundy
Department of Physics
Oregon State University
msg2071 (view) Author: jason Date: 2007-08-14.20:59:43
Yeah, I'm not sure about making the repository available - it's my 
company's code and there are passwords sprinkled throughout, if I'm 
understanding what you're asking for.

Thanks!

Jason

Eric Kow wrote:
> Eric Kow <eric.kow@gmail.com> added the comment:
> 
>> Not really - the sequence, if I could redo it would be pretty long.
> 
> Ok. Thanks anyway.
> 
>> I ended up moving the repo aside, re-getting it and then folding my 
>> changes back.
> 
> Glad to hear that you found a workaround.  I was going to suggest
> editing the pending by hand.
> 
>> I don't remember doing a 'darcs mv' for that locations.TMPL file --
>> maybe I did?
> 
>> There were a LOT of changes, so my guess is that something got corrupted 
>> a while ago.
> 
> If you could make your repository available, it might be helpful (it may
> let us ferret out the corruption), but I understand if that's not
> possible.
> 
> Otherwise, without a reproducible example, I'm not sure we can do
> anything with this.
> 
> Darcs: maybe a battery of quickcheck tests for pending?  Somehow
> generate a sequence of moves, adds, removes, and trivial hunk changes to
> make sure that the pending patch is always valid?
> 
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue510>
> __________________________________
msg2076 (view) Author: kowey Date: 2007-08-17.15:45:32
I'm marking this resolved in unstable, mostly because we can't reproduce it, and
partly because of the recent issue494 fix.  Feel free to reopen if anyone has
ideas, especially Jason if you find a way to reproduce it.

I'm somewhat doubtful that the two are related (issue494 involves applying a
patch), but there are some interesting similarities (move b -> a, weird stuff in
pending).

Cheers,

Eric

P.S.  If only we had some kind of magical obfuscater that could make it easy for
people to send us repos for forensics without revealing company secrets.
History
Date User Action Args
2007-08-06 18:15:12jasoncreate
2007-08-06 18:56:23koweysetstatus: unread -> unknown
messages: + msg2015
2007-08-06 19:34:10jasonsetmessages: + msg2016
2007-08-11 06:49:45koweysetmessages: + msg2041
2007-08-13 16:45:38droundysetmessages: + msg2057
2007-08-14 20:59:45jasonsetmessages: + msg2071
2007-08-17 15:45:35koweysetstatus: unknown -> resolved-in-unstable
messages: + msg2076
title: pending has conflicts -> There was an attempt to write an invalid pending! (1.0.9r1)
2008-09-04 21:31:20adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:34:55adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, jason
2009-08-06 20:32:10adminsetnosy: - beschmi
2009-08-10 22:07:04adminsetnosy: + jason, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:01:56adminsetnosy: - dagit
2009-08-25 17:49:20adminsetnosy: + darcs-devel, - simon
2009-08-27 14:07:16adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, jason, dmitry.kurochkin