darcs

Issue 558 singular rather than plural on "do you wish to revert these changes"

Title singular rather than plural on "do you wish to revert these changes"
Priority feature Status resolved
Milestone Resolved in
Superseder Nosy List bet, darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy
Assigned To
Topics ProbablyEasy

Created on 2007-11-01.15:59:32 by droundy, last changed 2009-08-27.14:02:13 by admin.

Messages
msg2227 (view) Author: droundy Date: 2007-11-01.15:59:31
We should change it so when there's only one change to be reverted, it says
"Do you wish to revert this change?".  It'll make users more confident in
saying yes.
-- 
David Roundy
Department of Physics
Oregon State University
msg2230 (view) Author: bet Date: 2007-11-01.21:57:50
2007-11-01T15:59:33 David Roundy:
> We should change it so when there's only one change to be
> reverted, it says "Do you wish to revert this change?". It'll make
> users more confident in saying yes.

Could we maybe say "do you want to revert this changeset", and leave
the plurality or otherwise for folks who care about what's in the
details of the changeset?

Any time I see a change request that lies in the irregular parts of
the english language as it's spoken by at least some allegedly
endlish-speakers at this point in history, my skin crawls.

-Bennett
msg2295 (view) Author: markstos Date: 2008-01-01.00:01:35
Where is this place where this occurs? Just running "darcs revert" with 1.0.9
looks like this:

$ darcs revert
hunk ./1.t 1
+b
Shall I revert this change? (1/?)  [ynWsfqadjkc], or ? for help:

###
...it is already singular.
msg2307 (view) Author: droundy Date: 2008-01-02.18:04:36
It's in the next query after you hit 'y' and then 'd' (indicating you only want
one change reverted).

darcs says:

Do you really want to revert these changes?

even though only one change was selected.
msg3021 (view) Author: kowey Date: 2008-02-01.08:40:42
I think my patch fixes this:
Tue Jan 29 16:36:33 GMT 2008  Eric Kow <E.Y.Kow@brighton.ac.uk>
  * [issue558] Singular 'do you want to revert this change?'
History
Date User Action Args
2007-11-01 15:59:33droundycreate
2007-11-01 21:57:51betsetstatus: unread -> unknown
nosy: + darcs-devel, bet
messages: + msg2230
2007-11-04 23:00:04koweysettopic: + ProbablyEasy
2008-01-01 00:01:36markstossetnosy: + markstos
messages: + msg2295
2008-01-02 18:04:37droundysetnosy: markstos, droundy, tommy, darcs-devel, kowey, beschmi, bet
messages: + msg2307
2008-02-01 08:40:44koweysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, darcs-devel, bet
messages: + msg3021
2008-08-05 23:29:34koweysetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:38:45adminsetnosy: + jast, Serware, dmitry.kurochkin, zooko, mornfall, simon, thorkilnaur, - droundy, bet
2009-08-06 20:35:38adminsetnosy: - beschmi
2009-08-10 22:09:27adminsetnosy: + bet, - zooko, jast, Serware, mornfall
2009-08-11 00:03:23adminsetnosy: - dagit
2009-08-25 17:52:26adminsetnosy: - simon
2009-08-27 14:02:13adminsetnosy: tommy, kowey, markstos, darcs-devel, thorkilnaur, bet, dmitry.kurochkin