darcs

Issue 816 corrupt patch in darcs-2

Title corrupt patch in darcs-2
Priority urgent Status duplicate
Milestone Resolved in
Superseder corrupt patch in darcs-2
View: 815
Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, zooko
Assigned To
Topics

Created on 2008-04-25.16:56:58 by zooko, last changed 2009-08-27.13:58:35 by admin.

Files
File name Uploaded Type Edit Remove
0000000142-8a9a56b2d267a619e1931053128a1edc6db2da2fd9545ef33dfa789ce71c261e zooko, 2008-04-25.16:56:56 application/octet-stream
Messages
msg4336 (view) Author: zooko Date: 2008-04-25.16:56:56
Folks:

This is the first serious bug I've encountered in darcs-2.  I  
recorded a patch, and it offered me the "rm file" change without  
first offering me the "delete every line of the file change".  I  
thought this was mildly unusual, but I assumed that darcs knew what  
it was doing and recorded that patch and pushed it into the central,  
append-only repository for my project:

http://allmydata.org/trac/tahoe/changeset/2504

However, now certain operations on this repository yield darcs errors:

> allmydata/tahoe/trunk-bug$ darcs query contents --quiet --match  
> "hash 20071207003658- 
> e01fd-9c5c4455756f14fb24bf465869d43a9b78e7d1e0.gz" "src/allmydata/ 
> client.py"
>
> darcs failed:  Error applying hunk to file ./misc/hatch-eggs.py

Or equivalently:

http://allmydata.org/trac/tahoe/browser/src/allmydata/client.py?rev=1656

This is a major problem for me -- the central, canonical repository  
for the open source project and company seems to have some corruption  
now (although the consequences of this corruption are minor).

So I have a few questions:

1.  Why did darcs-2 offer to record removal of a file without  
recording removal of its contents?

2.  How can I repair my central repository with minimal disruption to  
the other programmers who rely on it?

Regards,

Zooko

attached is the offending patch file:
Attachments
msg4337 (view) Author: zooko Date: 2008-04-25.16:57:54
duplicate of issue815
msg4555 (view) Author: droundy Date: 2008-05-07.15:15:26
The following patch updated the status of Issue817 to be resolved in the =
unstable branch:

* resolve Issue817: fix bug in conflict-handling with darcs-2 semantics.=20
This bug was due to the buggy use of a buggy function called
depends_uponFL.  I've removed this function, and am making this note
explicit so that noone else (including myself) will make the mistake of
resurrecting this function from the past.
msg4565 (view) Author: zooko Date: 2008-05-07.17:00:39
Hm.  So if that patch resolved Issue817, then why did unrelated Issue816 (which
is a mail-causes-duplicates duplicate of Issue815, which is an
independently-reported duplicate of Issue693) receive this update?

Perhaps the bug in our roundup that causes mail to generate duplicates also
causes "resolve IssueXYZ:" patches to poke the wrong issue numbers ??
History
Date User Action Args
2008-04-25 16:56:58zookocreate
2008-04-25 16:57:55zookosetpriority: urgent
status: unread -> duplicate
superseder: + corrupt patch in darcs-2
messages: + msg4337
nosy: tommy, beschmi, zooko
2008-05-07 15:15:28droundysetnosy: + droundy, dagit
messages: + msg4555
2008-05-07 17:00:40zookosetnosy: droundy, tommy, beschmi, zooko, dagit
messages: + msg4565
2009-08-06 17:58:27adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, mornfall, simon, kowey, thorkilnaur, - droundy
2009-08-06 21:03:16adminsetnosy: - beschmi
2009-08-10 22:20:02adminsetnosy: - markstos, darcs-devel, jast, Serware, mornfall
2009-08-11 00:11:20adminsetnosy: - dagit
2009-08-25 18:08:33adminsetnosy: + darcs-devel, - simon
2009-08-27 13:58:35adminsetnosy: tommy, kowey, darcs-devel, zooko, thorkilnaur, dmitry.kurochkin