Issue 855: fix bug where we were calling revertRepository when running with --dry-run. - Darcs bug tracker

Title	fix bug where we were calling revertRepository when running with --dry-run.
Priority	feature	Status	resolved
Milestone		Resolved in
Superseder		Nosy List	E.Y.Kow, darcs-devel, dmitry.kurochkin, jaredj, jch, kowey, thorkilnaur, tommy
Assigned To		Topics	ProbablyEasy

Created on 2008-05-16.13:20:22 by jch, last changed 2009-08-27.14:02:19 by admin.

Messages
msg4724 (view)	Author: jch	Date: 2008-05-16.13:20:21
$ cd ~/cpc $ darcs pull --dry-run -s ~kerneis/cpc > /dev/null $ cd ~kerneis/cpc $ darcs push --dry-run -s ~/cpc > /dev/null darcs: takeLock /home/invites/kerneis/cpc/_darcs/lock in /home/invites/kerneis/cpc: atomic_create /home/invites/kerneis/cpc/_darcs/lock in /home/invites/kerneis/cpc: permission denied (Permission denied) I know I don't have write access; but it's a dry run, for goodness' sake. This happens with both 1.0.9 and 2.0.0. Regards, Juliusz
msg4735 (view)	Author: kowey	Date: 2008-05-16.23:45:55
Downgrading (he says innocently). Perhaps it will suffice to modify Darcs.Repository.Internal.withRepoLock so that it checks for the presence of the DryRun flag?
msg4736 (view)	Author: kowey	Date: 2008-05-16.23:49:26
Assigning to myself to create a test case for bugs/
msg4758 (view)	Author: kowey	Date: 2008-05-19.08:04:18
Bug entry created. David thinks the global approach is fine (i.e. in the lock-creation code, check for the dry run flag). I'm going to slap on ProbablyEasy, though I do not know how true that really is.
msg4794 (view)	Author: E.Y.Kow	Date: 2008-05-20.15:35:30
The following patch updated the status of issue855 to be resolved: * Resolve issue855: avoid taking lock if using --dry-run
msg4799 (view)	Author: jch	Date: 2008-05-20.18:09:17
> The following patch updated the status of issue855 to be resolved: Thanks a lot, Eric. This is going to simplify my life a lot when I'm working on a shared filesystem with my students. Juliusz
msg4818 (view)	Author: droundy	Date: 2008-05-21.13:30:53
The following patch updated the status of issue855 to be resolved: * resolve issue855: fix bug where we were calling revertRepository when running with --dry-run.

History
Date	User	Action	Args
2008-05-16 13:20:22	jch	create
2008-05-16 23:35:11	kowey	link	issue856 superseder
2008-05-16 23:45:57	kowey	set	priority: feature nosy: + kowey status: unread -> unknown messages: + msg4735 title: Cannot ``push --dry-run'' without write access -> wish: avoid taking lock if using --dry-run
2008-05-16 23:49:27	kowey	set	status: unknown -> has-patch nosy: jch, tommy, beschmi, kowey, dagit messages: + msg4736 assignedto: kowey
2008-05-19 08:04:21	kowey	set	topic: + ProbablyEasy nosy: + jaredj messages: + msg4758 assignedto: kowey ->
2008-05-19 15:21:00	kowey	link	issue825 superseder
2008-05-20 15:35:32	E.Y.Kow	set	status: has-patch -> resolved-in-unstable nosy: + E.Y.Kow messages: + msg4794 title: wish: avoid taking lock if using --dry-run -> avoid taking lock if using --dry-run
2008-05-20 18:09:20	jch	set	nosy: jch, tommy, beschmi, kowey, dagit, jaredj, E.Y.Kow messages: + msg4799
2008-05-20 18:22:05	kowey	link	issue869 superseder
2008-05-21 13:30:55	droundy	set	nosy: + droundy messages: + msg4818 title: avoid taking lock if using --dry-run -> fix bug where we were calling revertRepository when running with --dry-run.
2008-08-05 23:29:55	kowey	set	status: resolved-in-unstable -> resolved nosy: droundy, jch, tommy, beschmi, kowey, dagit, jaredj, E.Y.Kow
2009-08-06 17:58:44	admin	set	nosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, jch, jaredj, E.Y.Kow
2009-08-06 21:04:53	admin	set	nosy: - beschmi
2009-08-10 22:20:33	admin	set	nosy: + E.Y.Kow, jch, jaredj, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-11 00:14:00	admin	set	nosy: - dagit
2009-08-25 18:08:49	admin	set	nosy: + darcs-devel, - simon
2009-08-27 14:02:19	admin	set	nosy: jch, tommy, kowey, darcs-devel, thorkilnaur, jaredj, dmitry.kurochkin, E.Y.Kow