darcs

Patch 102 break up ShowContents repo fetching functions into functions that

Title break up ShowContents repo fetching functions into functions that
Superseder Nosy List ganesh, kowey, thomashartman1
Related Issues
Status rejected Assigned To
Milestone

Created on 2009-11-26.00:02:20 by thomashartman1, last changed 2012-05-11.21:05:36 by thomashartman1. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
refactorShowContentsFunctions.dpatch thomashartman1, 2009-11-26.00:02:19 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg9498 (view) Author: thomashartman1 Date: 2009-11-26.00:02:19
On Wed, Nov 25, 2009 at 2:58 PM, Thomas Hartman
<thomashartman1@googlemail.com> wrote:
> attached.
>
> --
> Need somewhere to put your code? http://patch-tag.com
> Want to build a webapp? http://happstack.com
>



-- 
Need somewhere to put your code? http://patch-tag.com
Want to build a webapp? http://happstack.com
Attachments
msg9540 (view) Author: ganesh Date: 2009-12-06.01:30:43
The first patch in this bundle is the same as the one I commented on in
patch103. If amending it will be hard because of dependency problems, feel free
to just submit another patch on top of it.

The second breaks up a single function into several pieces. Can you motivate a
bit more why the new pieces are actually useful? Other than that it looks fine.
msg10248 (view) Author: dagit Date: 2010-03-18.02:42:42
Has this patch been obsoleted?

Thanks!
Jason
msg10650 (view) Author: ganesh Date: 2010-04-03.12:52:25
Marking this as "amend-requested" which isn't quite accurate as just some 
comments would be enough, but it reflects the fact that it's waiting for 
action from the submitter.
msg11583 (view) Author: kowey Date: 2010-06-24.16:16:57
Hi Thomas, Could we get some clarification on the motivation for this
patch?  Thanks!
msg15673 (view) Author: gh Date: 2012-05-11.20:11:34
The codebase against which this bundle was initially done has changed
too much (2 y 1/2), and no explication is provided. Rejecting it.
msg15674 (view) Author: thomashartman1 Date: 2012-05-11.21:05:36
Yes, I can't remember the context anymore.

On Fri, May 11, 2012 at 1:11 PM, Guillaume Hoffmann <bugs@darcs.net> wrote:
>
> Guillaume Hoffmann <guillaumh@gmail.com> added the comment:
>
> The codebase against which this bundle was initially done has changed
> too much (2 y 1/2), and no explication is provided. Rejecting it.
>
> ----------
> status: in-discussion -> rejected
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch102>
> __________________________________
History
Date User Action Args
2009-11-26 00:02:20thomashartman1create
2009-11-26 00:05:14darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html
2009-12-06 01:30:45ganeshsetstatus: needs-review -> review-in-progress
nosy: + ganesh
messages: + msg9540
2009-12-06 01:35:35ganeshsetassignedto: ganesh
2010-03-18 02:42:42dagitsetnosy: + dagit
messages: + msg10248
2010-04-03 12:52:26ganeshsetstatus: review-in-progress -> followup-requested
assignedto: ganesh -> thomashartman1
messages: + msg10650
2010-06-24 16:16:58koweysetstatus: followup-requested -> in-discussion
nosy: + kowey, - darcs-users, dagit
assignedto: thomashartman1 ->
messages: + msg11583
title: Re: break up ShowContents repo fetching functions into functions that -> break up ShowContents repo fetching functions into functions that
2011-05-10 20:36:28darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-ad860e84c9b1f19a60dee1064a37431afb3dbc6c
2012-05-11 20:11:34ghsetstatus: in-discussion -> rejected
messages: + msg15673
2012-05-11 21:05:36thomashartman1setmessages: + msg15674