I have created a follow-up patch for patch1066 which is also included.
(I was unsure whether to amend or to follow-up. I decided to follow-up
because of http://darcs.net/Development/PatchReview which states: "we
no longer request patch amendments so much as follow on patches")
2 patches for repository /home/sebfisch/Code/Haskell/darcs/screened:
Sat Mar 9 21:22:19 CET 2013 Sebastian Fischer <mail@sebfisch.de>
* resolve issue2312: posthooks for 'record' and 'amend-record' should receive DARCS_PATCHES
I have extended the 'record' and 'amend-record' commands to supply the
environment variable DARCS_PATCHES to posthooks.
The contents of DARCS_PATCHES is computed and provided by a new
function `Darcs.UI.Commands.Util.setChangesEnvAfter` that is used to
wrap the 'record' and 'amend-record' commands.
This function reads the repository before and after the executed
command. It uses the existing function
`Darcs.Patch.Depends.findCommonWithThem` to compute the changes made
by the command and `Darcs.UI.Commands.setEnvDarcsPatches` to provide
them to posthooks.
Sun Mar 10 22:55:56 CET 2013 Sebastian Fischer <mail@sebfisch.de>
* Follow-up on patch1066 resolving issue2312.
Instead of recomputing the changes made by record and amend-record by
reading the repository twice, those changes are now reused in the
internal functions computing them.
It turns out that reuse is simple. It does not even justify the
wrapper function `setChangesEnvAfter` so I removed it.
The tests still pass.
Attachments
|