darcs

Patch 1135 Resolve Issue1416: put log files in tempdir instead of...

Title Resolve Issue1416: put log files in tempdir instead of...
Superseder Nosy List alex.aegf
Related Issues
Status accepted Assigned To
Milestone

Created on 2014-04-07.03:57:47 by alex.aegf, last changed 2014-04-08.19:18:47 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt alex.aegf, 2014-04-07.03:57:46 text/x-darcs-patch
patch-preview.txt alex.aegf, 2014-04-08.17:05:50 text/x-darcs-patch
patch-preview.txt gh, 2014-04-08.19:18:05 text/x-darcs-patch
resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch alex.aegf, 2014-04-07.03:57:46 application/x-darcs-patch
resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch alex.aegf, 2014-04-08.17:05:50 application/x-darcs-patch
resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch gh, 2014-04-08.19:18:05 application/x-darcs-patch
unnamed alex.aegf, 2014-04-07.03:57:46
unnamed alex.aegf, 2014-04-08.17:05:50
unnamed gh, 2014-04-08.19:18:05
See mailing list archives for discussion on individual patches.
Messages
msg17274 (view) Author: alex.aegf Date: 2014-04-07.03:57:46
1 patch for repository http://darcs.net:

Mon Apr  7 00:55:56 ART 2014  Ale Gadea <alex.aegf@gmail.com>
  * Resolve Issue1416: put log files in tempdir instead of in working dir.
  
  The temporary files are found in _darcs.
  For the commands amend-record, record and tag, the temp file is path_description.txt
  and is persistent, ie always have the last message whether failed or not the command.
  For send, we use two files, darcs-send for the editing and darcs-send.final for the 
  backup. If all is ok, the files are removed.
Attachments
msg17281 (view) Author: gh Date: 2014-04-07.19:15:24
Hi Ale.

When sending an amended version of a patch, it is better to send
it with the same ticket number, in the present case it would have
been:

     darcs send --mail --subject '[patch1131]'

Let's continue with that ticket now (1134).

The patch is almost good to go, save some details. I've tested it and
it works fine in practice.

* in Send.hs, you probably want to rename "updateFile" to something
like "updatedFile", or "finalFile", "fileDotFinal" ..
* please remove or edit the unnecessary hunks and lines I gave you in
my previous message; keeping patches as minimal as possible makes
cherry-picking easier (say if we want to apply this patch to branch
2.8)
* in the patch description:  path_description.txt  -> patch_description.txt
msg17297 (view) Author: alex.aegf Date: 2014-04-08.17:05:50
1 patch for repository http://darcs.net:

Tue Apr  8 13:45:28 ART 2014  Ale Gadea <alex.aegf@gmail.com>
  * Resolve Issue1416: put log files in tempdir instead of in working dir.
    
  The temporary files are found in _darcs.
  For the commands amend-record, record and tag, the temp file is patch_description.txt
  and is persistent, ie always have the last message whether failed or not the command.
  For send, we use two files, darcs-send for the editing and darcs-send.final for the 
  backup. If all is ok, the files are removed.
Attachments
msg17299 (view) Author: gh Date: 2014-04-08.19:18:05
Shell tests pass; I'm accepting the patch with a warning fix.

2 patches for repository http://darcs.net:

Tue Apr  8 13:45:28 ART 2014  Ale Gadea <alex.aegf@gmail.com>
  * Resolve Issue1416: put log files in tempdir instead of in working dir.
    
  The temporary files are found in _darcs.
  For the commands amend-record, record and tag, the temp file is patch_description.txt
  and is persistent, ie always have the last message whether failed or not the command.
  For send, we use two files, darcs-send for the editing and darcs-send.final for the 
  backup. If all is ok, the files are removed.
  

Tue Apr  8 16:13:04 ART 2014  Guillaume Hoffmann <guillaumh@gmail.com>
  * fix warning in Record
Attachments
History
Date User Action Args
2014-04-07 03:57:47alex.aegfcreate
2014-04-07 19:15:24ghsetmessages: + msg17281
2014-04-08 17:05:50alex.aegfsetfiles: + patch-preview.txt, resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch, unnamed
messages: + msg17297
2014-04-08 19:18:05ghsetfiles: + patch-preview.txt, resolve-issue1416_-put-log-files-in-tempdir-instead-of-in-working-dir_.dpatch, unnamed
messages: + msg17299
2014-04-08 19:18:47ghsetstatus: needs-screening -> accepted