darcs

Patch 1231 use decodeString to convert command line args up front

Title use decodeString to convert command line args up front
Superseder Nosy List bfrk, gh
Related Issues
Status accepted Assigned To
Milestone 2.10.0

Created on 2014-11-17.22:11:22 by bfrk, last changed 2015-02-16.20:18:02 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2014-11-17.22:11:21 text/x-darcs-patch
unnamed bfrk, 2014-11-17.22:11:21
use-decodestring-to-convert-command-line-args-up-front.dpatch bfrk, 2014-11-17.22:11:21 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg17836 (view) Author: bfrk Date: 2014-11-17.22:11:21
Sending this patch separately and with an amended patch name, as I think it
makes sense regardless of issue2416.

1 patch for repository http://darcs.net:

patch 02ef1a6d50cd7e0e8683ce3109d6a658597b1890
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Mon Nov 17 23:11:14 CET 2014
  * use decodeString to convert command line args up front
  
  Also make it return IO String, thus saving an unsafePerformIO. This is
  possible because decodeString is no longer used in pure functions.
Attachments
msg17968 (view) Author: bfrk Date: 2015-01-31.18:50:22
Straight forward cleanup patch => self-accept
msg18140 (view) Author: ganesh Date: 2015-02-16.07:30:51
I think we need this in 2.10, otherwise the latin9 test fails.

Guillaume - shout if you object, otherwise I'll push it to the branch.
msg18141 (view) Author: gh Date: 2015-02-16.20:18:02
Agreed. I'll push it after compiling and testing it.

2015-02-16 4:30 GMT-03:00 Ganesh Sittampalam <bugs@darcs.net>:
>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> I think we need this in 2.10, otherwise the latin9 test fails.
>
> Guillaume - shout if you object, otherwise I'll push it to the branch.
>
> ----------
> milestone:  -> 2.10.0 HEAD
> nosy: +gh
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch1231>
> __________________________________
History
Date User Action Args
2014-11-17 22:11:22bfrkcreate
2014-11-17 22:11:39bfrksetstatus: needs-screening -> needs-review
2015-01-31 18:50:22bfrksetstatus: needs-review -> accepted
messages: + msg17968
2015-02-16 07:30:52ganeshsetnosy: + gh
messages: + msg18140
milestone: 2.10.0
2015-02-16 20:18:02ghsetmessages: + msg18141