darcs

Patch 1248 accept issue2333: Error message when pushing and darcs...

Title accept issue2333: Error message when pushing and darcs...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2015-01-25.23:52:05 by bfrk, last changed 2015-03-04.01:21:13 by gh.

Files
File name Status Uploaded Type Edit Remove
accept-issue2333_-error-message-when-pushing-and-darcs-not-in-path.dpatch bfrk, 2015-01-25.23:52:05 application/x-darcs-patch
patch-preview.txt bfrk, 2015-01-25.23:52:05 text/x-darcs-patch
patch-preview.txt ganesh, 2015-02-10.07:15:24 text/x-darcs-patch
skip-issue2333-test-on-ghc-7_4.dpatch ganesh, 2015-02-10.07:15:24 application/x-darcs-patch
unnamed bfrk, 2015-01-25.23:52:05
unnamed ganesh, 2015-02-10.07:15:24
See mailing list archives for discussion on individual patches.
Messages
msg17954 (view) Author: bfrk Date: 2015-01-25.23:52:05
1 patch for repository http://darcs.net/screened:

patch c129beda914db7bf2e5ee28db20ceda77c21d145
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Mon Jan 26 00:52:08 CET 2015
  * accept issue2333: Error message when pushing and darcs not in path
Attachments
msg18052 (view) Author: ganesh Date: 2015-02-09.19:30:42
We need to also disable the test for GHC 7.4. Unfortunately darcs isn't 
built with '-rtsopts' by default so we can't just look at the output of 
'darcs +RTS -V'.

Perhaps we should use -rtsopts unconditionally for darcs-test?
msg18053 (view) Author: bfrk Date: 2015-02-09.21:43:11
Yes that sounds like a good idea.
msg18055 (view) Author: ganesh Date: 2015-02-10.07:15:24
Actually when I got to implementing it seemed cleaner to pass the GHC version
through with an environment variable.

1 patch for repository darcs-unstable@darcs.net:screened:

Tue Feb 10 06:54:24 GMT 2015  Ganesh Sittampalam <ganesh@earth.li>
  * skip issue2333 test on GHC 7.4
Attachments
msg18218 (view) Author: ganesh Date: 2015-02-24.06:33:53
Looks fine, accepting (along with the patches that fix the problem). 
Strangely the test doesn't fail on Windows.

Also accepting my own patch which is fairly simple and has been around 
for a couple of weeks.
msg18252 (view) Author: gh Date: 2015-03-04.01:21:13
Pushing it into branch 2.10.
History
Date User Action Args
2015-01-25 23:52:05bfrkcreate
2015-01-26 17:34:54bfrksetstatus: needs-screening -> needs-review
2015-02-09 19:30:42ganeshsetmessages: + msg18052
2015-02-09 21:43:11bfrksetmessages: + msg18053
2015-02-10 07:15:24ganeshsetfiles: + patch-preview.txt, skip-issue2333-test-on-ghc-7_4.dpatch, unnamed
messages: + msg18055
2015-02-24 06:33:54ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg18218
2015-03-04 01:21:13ghsetstatus: accepted-pending-tests -> accepted
messages: + msg18252