darcs

Patch 1273 cleanup: removed all code related to the --hashed flag

Title cleanup: removed all code related to the --hashed flag
Superseder Nosy List bfrk
Related Issues
Status rejected Assigned To
Milestone

Created on 2015-02-11.00:21:10 by bfrk, last changed 2015-02-13.02:12:27 by bfrk.

Files
File name Status Uploaded Type Edit Remove
cleanup_-removed-all-code-related-to-the-__hashed-flag.dpatch bfrk, 2015-02-11.00:21:10 application/x-darcs-patch
patch-preview.txt bfrk, 2015-02-11.00:21:10 text/x-darcs-patch
unnamed bfrk, 2015-02-11.00:21:10
See mailing list archives for discussion on individual patches.
Messages
msg18071 (view) Author: bfrk Date: 2015-02-11.00:21:10
1 patch for repository http://darcs.net/screened:

patch 650a97f5c8e77968fa88db148bdf7d8636e4e9aa
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Tue Feb 10 23:06:29 CET 2015
  * cleanup: removed all code related to the --hashed flag
  
  The option had already been removed from the init command, this patch only
  cleans up dead (or out-commented) code.
Attachments
msg18075 (view) Author: bfrk Date: 2015-02-11.01:01:44
Not screening this yet because it is debatable whether we want to keep
it so we can display the warning message. Perhaps it would make even
more sense to just leave it as an alias for --darcs1. Perhaps we should
display only one long option name in the help (the first in the list)
and regard all others as compatibility aliases?
msg18080 (view) Author: gh Date: 2015-02-11.23:37:05
It was not dead code. The discussion about what to do with --hashed
already happened: http://bugs.darcs.net/patch1012

What happens is that the last released version of darcs (2.8) still
has --hashed, and the next one uses --darcs-1.

I suggest we reject the patch.
msg18115 (view) Author: bfrk Date: 2015-02-13.02:12:27
I have now implemented generic support deprecated options and use that
for --hashed. Will send a patch soon.
History
Date User Action Args
2015-02-11 00:21:10bfrkcreate
2015-02-11 01:01:44bfrksetmessages: + msg18075
2015-02-11 23:37:06ghsetmessages: + msg18080
2015-02-13 02:12:27bfrksetstatus: needs-screening -> rejected
messages: + msg18115