darcs

Patch 1354 remove a parameter from locally defined isInteractive ...

Title remove a parameter from locally defined isInteractive ...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2015-06-11.18:44:14 by bfrk, last changed 2015-06-16.18:15:25 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2015-06-11.18:44:14 text/x-darcs-patch
remove-a-parameter-from-locally-defined-isinteractive-_amend_-record_.dpatch bfrk, 2015-06-11.18:44:14 application/x-darcs-patch
unnamed bfrk, 2015-06-11.18:44:14
See mailing list archives for discussion on individual patches.
Messages
msg18459 (view) Author: bfrk Date: 2015-06-11.18:44:14
This came up when solving issue2444 but is independent. Not for screened
yet: on the one hand it simplifies the code, on the other it destroys the
symmetry with the version of isInteractive from Darcs.UI.Flags. So I am not
sure this is a definite improvement.

1 patch for repository http://darcs.net/screened:

patch a98bc4d6b8b53dc23e58f28741835ef55232c634
Author: Ben Franksen <benjamin.franksen@helmholtz-berlin.de>
Date:   Thu Jun 11 14:43:22 CEST 2015
  * remove a parameter from locally defined isInteractive (amend, record)
  
  The parameter was always True, so can as well be moved into the definition
  of isInteractive.
Attachments
msg18480 (view) Author: bfrk Date: 2015-06-13.14:35:44
Screening this now. The command specific isInteractive functions have
all different types anyway so if confusion arises the type checker will
complain.
msg18517 (view) Author: ganesh Date: 2015-06-16.18:04:37
Makes sense.
History
Date User Action Args
2015-06-11 18:44:14bfrkcreate
2015-06-13 14:35:44bfrksetstatus: needs-screening -> needs-review
messages: + msg18480
2015-06-16 18:04:38ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg18517
2015-06-16 18:15:25ganeshsetstatus: accepted-pending-tests -> accepted