Patch 1691: resolve issue2588: no longer use withTempDirectory in withNewDirectory - Darcs bug tracker

Title	resolve issue2588: no longer use withTempDirectory in withNewDirectory
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone	2.14.1

Created on 2018-05-28.15:28:56 by bfrk, last changed 2018-06-24.10:20:18 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue2588_-no-longer-use-withtempdirectory-in-withnewdirectory.dpatch		bfrk, 2018-05-31.11:17:36	text/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg20135 (view)	Author: bfrk	Date: 2018-05-28.15:28:56
The first patch has a conflict, see my comments on issue2588 for details. 2 patches for repository http://darcs.net/screened: patch 357a78ec7167d6b75cdc805d71effeb4d7ac030c Author: Ben Franksen <ben.franksen@online.de> Date: Mon May 28 17:12:05 CEST 2018 * resolve issue2588: no longer use withTempDirectory in withNewDirectory patch 769dd802b17bd54be299c4df060b1db4bffbd0b1 Author: Ben Franksen <ben.franksen@online.de> Date: Mon May 28 17:15:59 CEST 2018 * resolve conflicts after pulling fix for issue2588 from branch-2.14 Attachments resolve-issue2588_-no-longer-use-withtempdirectory-in-withnewdirectory.dpatch
msg20137 (view)	Author: bfrk	Date: 2018-05-30.11:38:31
The patch is buggy, please ignore. Will re-send.
msg20139 (view)	Author: bfrk	Date: 2018-05-31.11:17:36
Attached is a new fixed bundle. I find it interesting that this latest version of withNewDirectory is much simpler than previous versions. Attachments resolve-issue2588_-no-longer-use-withtempdirectory-in-withnewdirectory.dpatch
msg20142 (view)	Author: bfrk	Date: 2018-06-04.15:43:02
I am now screening this bundle and will also push the fix to releases/branch-2.14.
msg20175 (view)	Author: ganesh	Date: 2018-06-24.10:20:18
Looks good

History
Date	User	Action	Args
2018-05-28 15:28:56	bfrk	create
2018-05-30 11:38:32	bfrk	set	messages: + msg20137
2018-05-31 10:51:12	bfrk	set	files: - resolve-issue2588_-no-longer-use-withtempdirectory-in-withnewdirectory.dpatch
2018-05-31 11:17:36	bfrk	set	files: + resolve-issue2588_-no-longer-use-withtempdirectory-in-withnewdirectory.dpatch messages: + msg20139
2018-06-04 15:43:02	bfrk	set	status: needs-screening -> needs-review messages: + msg20142
2018-06-10 11:05:13	ganesh	set	milestone: 2.14.1
2018-06-24 10:20:18	ganesh	set	status: needs-review -> accepted messages: + msg20175