darcs

Patch 1838 resolve issue2626: treat applyToWorking ... (and 1 more)

Title resolve issue2626: treat applyToWorking ... (and 1 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-06-17.07:56:01 by bf, last changed 2019-07-28.19:38:42 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2019-06-17.07:56:01 text/x-darcs-patch
resolve-issue2626_-treat-applytoworking-more-uniformly.dpatch bf, 2019-06-17.07:56:01 application/x-darcs-patch
unnamed bf, 2019-06-17.07:56:01 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg20846 (view) Author: bf Date: 2019-06-17.07:56:01
2 patches for repository /home/ben/src/darcs/sent:

patch 173e8e8e4ffd993d761de1cc441f2012e01e7e5c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jun 17 08:32:58 CEST 2019
  * resolve issue2626: treat applyToWorking more uniformly
  
  This factors catching IO errors into applyToWorking with a generic error
  message that should fit all use cases. In case of the 'convert darcs-2'
  command, the extra clarification that suggests to use --no-workingdir has
  been removed as I find it misleading and cannot see how that could actually
  help: we have created the whole working tree ourselves, so if applying the
  patches fails something really weird (like another process interfering with
  the working tree) must be going on.
  
  It also adds a number of withSignalsBlocked to wrap the calls to
  applyToWorking where they were missing. Where possible, the scope of actions
  under withSignalsBlocked is extended to include finalization and/or updating
  the pending patch. This has previously been the case for some commands but
  not all of them.

patch a02674ef3cfdc0c50d827bf13aaa8640684dc664
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jun 17 08:50:04 CEST 2019
  * remove the (now) unused function 'revertable'
Attachments
msg20983 (view) Author: ganesh Date: 2019-07-28.13:45:06
Looks fine.
History
Date User Action Args
2019-06-17 07:56:01bfcreate
2019-06-18 13:10:19bfsetstatus: needs-screening -> needs-review
2019-07-28 13:45:06ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg20983
2019-07-28 19:38:42ganeshsetstatus: accepted-pending-tests -> accepted