darcs

Patch 1869 use new TestablePrim alias in the harnes... (and 3 more)

Title use new TestablePrim alias in the harnes... (and 3 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2019-08-12.14:26:19 by ganesh, last changed 2019-08-26.20:46:53 by bf.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2019-08-12.14:26:19 text/x-darcs-patch
unnamed ganesh, 2019-08-12.14:26:19 text/plain
use-new-testableprim-alias-in-the-harness-instead-of-primpatch.dpatch ganesh, 2019-08-12.14:26:19 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg21083 (view) Author: ganesh Date: 2019-08-12.14:26:19
This bundle is about the last two patches, but depends on the ones
I already send in patch1868. Since I'm waiting a bit to screen
that, I'll do the same for this.

I did some refactoring of the type class usage in the test harness
so we don't need the dummy instances of various classes for
NamedPrim any more.

4 patches for repository darcs-unstable@darcs.net:screened:

patch 3724864fa80ecfff09cd0cd5c95e25f27cb261da
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 15:13:15 BST 2019
  * use new TestablePrim alias in the harness instead of PrimPatch
  
  This allows the removal of a bunch of dummy instances for NamedPrim
  

patch b9f905c283113fecf2577520182efdf8c55dabf8
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 14:30:57 BST 2019
  * replace commenting out with if False in qc_V1P1
  
  Predictably the code had rotted a bit, but it looks like
  from history that commute_properties is now pair_properties

patch e3458e21393e36c2c29e8f560f4a275a6cc584f3
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 14:41:26 BST 2019
  * replace some undefineds with TypeApplications

patch 28dd912fa34e8823898e1caaef0385c8d88996e6
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Mon Aug 12 15:24:41 BST 2019
  * pass a PrimCanonize dictionary explicitly when needed
  
  This allows us to get rid of the dummy instance for
  PrimCanonize (NamedPrim prim)
Attachments
msg21085 (view) Author: bf Date: 2019-08-12.15:08:30
Yes, that's a good idea. No objections at all.
msg21220 (view) Author: bf Date: 2019-08-26.20:46:53
All good.
History
Date User Action Args
2019-08-12 14:26:19ganeshcreate
2019-08-12 15:08:30bfsetstatus: needs-screening -> needs-review
messages: + msg21085
2019-08-26 20:46:53bfsetstatus: needs-review -> accepted
messages: + msg21220