Patch 2162 patches proposed for 2.16.4; draft

Title patches proposed for 2.16.4; draft
Superseder Nosy List bf
Related Issues
Status needs-screening Assigned To

Created on 2021-03-10.14:48:47 by bf, last changed 2021-03-10.14:48:47 by bf.

File name Status Uploaded Type Edit Remove
add-changelog-for-2_16_4.dpatch bf, 2021-03-10.14:48:44 application/x-darcs-patch
patch-preview.txt bf, 2021-03-10.14:48:44 text/x-darcs-patch
unnamed bf, 2021-03-10.14:48:44 text/plain
See mailing list archives for discussion on individual patches.
msg22655 (view) Author: bf Date: 2021-03-10.14:48:44
This bundle is for branch-2.16. I have pulled all bug fixes from screened,
plus a few dependencies I decided to pull along instead of rebasing or
resolving conflicts.

Ganesh, it would be nice if you could review these patches with priority. As
I wrote in the changelog, issue2674 is a pretty serious bug that could lead
to repo corruption, which is why I want to release 2.16.4 ASAP.

21 patches for repository http://darcs.net/releases/branch-2.16:

patch 1295fec64bd3d19978bc7be36ed664606c61d3f8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 10 09:45:58 CET 2021
  * add changelog for 2.16.4

patch 24f5930d6c2958a01462ecbda10bbdadf0e7c90c
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Tue Dec 22 12:45:05 CET 2020
  * bash_completion: use '--list-options' before any other option
  This is so to avoid that, e.g.:
  $ darcs record -m <Tab><Tab>
  results in a patch named '--list-options' being recorded.

patch e71832422d19674725e1034a29eca4c8fbc644b1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec 18 10:03:31 CET 2020
  * resolve issue2670: convert "." to absolute path when creating a repo
  Note that this is what we also do in Darcs.Repository.Identify.

patch c36d5a2bdf3aa4cca96f5d778252ca50c87e4868
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Dec 23 17:15:22 CET 2020
  * zsh completion: use '--list-options' before any other option
  See the corresponding change in the bash completion for details.

patch 7048704e6f8772f7e021bd876ed35baa6ef04de0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Dec 23 17:23:59 CET 2020
  * zsh completion: improve the get/clone case
  Moving the special case for get/clone down into the catch-all case for the
  current word allows it to complete options and local paths.

patch 43c823f6c858101ffbb237f44f3a3ad92ad79349
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec 25 11:07:36 CET 2020
  * fix errors in zsh completions, add comments
  This fixes a stupid cut-and-paste error where I used x instead of words.
  Also, replacing the first option arg works only if the is an option arg in
  the first place, we need to properly insert --list-options.

patch 954ba7d6aa1937d26ce534a83fd282d33e521461
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov  5 13:50:44 CET 2020
  * bugfix: --leave-test-dir should be off by default

patch 3ae83321a2b5fcf0c08cdcf6f1ac1cf19266e127
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct 28 00:20:18 CET 2020
  * avoid useless CPP in D.U.Index and D.R.State
  We can use the same action (renameFile instead of removeFile) for both
  Windows and Posix. The point here is that the index may still be open via an
  mmapped ForeignPtr, so removing it is not portable, but renaming it should
  work on all systems.

patch 697902978ac4e171aad080a1baa57e34f3531bbf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 26 18:33:10 CET 2020
  * Darcs.Util.Index: rename updateIndex to treeFromIndex
  This function does not update the index, it merely creates a Tree out of an
  Index. This also avoids the name collision with the function from
  Darcs.Repository.State which does update the index. Also add haddocks and
  rename a local variable that denotes a tree, not an index.

patch e51d37deed0bcf9e9d7216225b425118591b1eb5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct 28 00:35:36 CET 2020
  * rename D.Util.Index.readIndex to openIndex
  This is a more fitting name since this function merely creates a cursor for
  the index without actually reading anything interesting (besides the magic
  word). It also resolves the last name conflict in D.R.State which means we
  can now import D.Util.Index unqualified.

patch 0c003b272def1c5c65cdc6827905acc2c84d5429
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct 29 15:01:41 CET 2020
  * simplify the logic that handles existence and validity of the index

patch df9b1e6a2384680dda7d6e67ba32241e5bc0c7f1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 30 09:01:02 CET 2020
  * add a few debug messages to D.R.State

patch 23bcf38240654ed5bda0f984950c8c490620bf52
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  9 20:05:02 CET 2021
  * bugfix in readPendingAndMovesAndUnrecorded
  This bug was revealed by patch f28ec42284caa0477537bb5741762abf0ab31b02
  "fail in Darcs.Util.Tree.Monad.rename if source does not exist". We must not
  apply the detected moves to the working tree, since detecting these moves
  means that the working tree already has those moves "applied". Also, in case
  we don't use the index, we want to restrict the plain working tree with the
  modified pending tree (i.e. with the detected moves applied), not the
  unmodified one.

patch 460204b44fc8ff465276a719c1ec81630cff8c5b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec  4 07:47:51 CET 2020
  * resolve issue2668: part2
  We have to catch IO errors when calling createOrUpdatePatchIndexDisk as this
  is not an essential failure and we are already past finalizing any other
  changes we made.

patch 3ff28f48ddbc202889e47bc0111a9c27984597f0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 10 08:22:58 CET 2021
  * bump version to 2.16.4

patch 7ffb158bdd5282b0552f1c4bcd15a6a3f440cbb1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec  4 07:12:40 CET 2020
  * resolve issue2668/part1
  This fixes the problem that causes storing the patch-index to fail if the
  parent of the repodir is read-only.

patch 9e066dc3b9110a570bbf4d5b4ad137d1f7a9cab1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Nov 20 17:46:10 CET 2020
  * resolve issue2667: catch IO errors in seekRepo
  When we (recursively) cd ".." to determine if we are in a darcs repo, we may
  well hit an IO error, such as permission denied. We now catch such errors,
  emit a warning, and return Nothing (not in a repo).

patch 733e1eb0c2cc1080f059d0ea2ee3eac9095bbe42
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jul 17 19:37:33 CEST 2020
  * cleanup D.U.Tree.Monad: remove classes TreeRO and TreeRW
  This merely turns the former methods into plain overloaded functions.

patch f28ec42284caa0477537bb5741762abf0ab31b02
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  9 17:40:02 CET 2021
  * fail in Darcs.Util.Tree.Monad.rename if source does not exist

patch 46bb7acd45b236920abf807efeef7544de76d7d0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  9 17:39:18 CET 2021
  * resolve issue2674: moving unadded files

patch a214ce5bc100c074dd04afcd8cc736aaa4051a86
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 10 13:06:33 CET 2021
  tagged 2.16.4
Date User Action Args
2021-03-10 14:48:47bfcreate