1 patch for repository http://darcs.net:

Sat May 15 18:00:46 CEST 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away

Attachments

• resolve-issue1784_-push-and-pull-print-remote-address-right-away.dpatch
• unnamed

A little explanation:

the problem this patch solves is that darcs pull and darcs push first
wait to have an answer from the server before printing its address.
This can be annoying when the server is down or when you don't
remember what is the default server of your repository.

More generally, it is a good usability practise to tell the user why
they have to wait for the program to respond.

guillaume

On Sat, May 15, 2010 at 6:02 PM, gh <bugs@darcs.net> wrote:
>
> New submission from gh <guillaumh@gmail.com>:
>
> 1 patch for repository http://darcs.net:
>
> Sat May 15 18:00:46 CEST 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>  * resolve issue1784: push and pull print remote address right away
>
> ----------
> files: resolve-issue1784_-push-and-pull-print-remote-address-right-away.dpatch, unnamed
> messages: 11074
> nosy: gh
> status: needs-review
> title: resolve issue1784: push and pull print remote address ...
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch250>
> __________________________________

gh <bugs@darcs.net> writes:

> Sat May 15 18:00:46 CEST 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * resolve issue1784: push and pull print remote address right away
>
> [resolve issue1784: push and pull print remote address right away
> Guillaume Hoffmann <guillaumh@gmail.com>**20100515160046
>  Ignore-this: 345d1244aee3645ae6591104b06b8c1d
> ] hunk ./src/Darcs/Commands/Pull.lhs 198
>    -- Test to make sure we aren't trying to pull from the current repo
>    when (null repodirs) $
>          fail "Can't pull from current repository!"
> -  (Sealed them, Sealed compl) <- readRepos repository opts repodirs
>    old_default <- getPreflist "defaultrepo"
>    setDefaultrepo (head repodirs) opts
>    mapM_ (addToPreflist "repos") repodirs
> hunk ./src/Darcs/Commands/Pull.lhs 204
>    when (old_default == repodirs) $
>        let pulling = if DryRun `elem` opts then "Would pull" else "Pulling"
>        in  putInfo opts $ text $ pulling++" from "++concatMap formatPath repodirs++"..."
> +  (Sealed them, Sealed compl) <- readRepos repository opts repodirs
^^ The side effect of this is that we pollute the repo list
(_darcs/prefs/repos) with typos and such (i.e. repositories that are
unusable)... So I would argue that what should be moved is the message,
not the readRepos call.

> hunk ./src/Darcs/Commands/Push.lhs 125
>  prepareBundle :: forall p C(r u t) . (RepoPatch p) => [DarcsFlag] -> String -> Repository p C(r u t) ->
>                  IO (Doc)
>  prepareBundle opts repodir repository = do
> -  them <- identifyRepositoryFor repository repodir >>= read_repo
>    old_default <- getPreflist "defaultrepo"
>    setDefaultrepo repodir opts
>    when (old_default == [repodir]) $
> hunk ./src/Darcs/Commands/Push.lhs 130
>         let pushing = if DryRun `elem` opts then "Would push" else "Pushing"
>         in  putInfo opts $ text $ pushing++" to "++formatPath repodir++"..."
> +  them <- identifyRepositoryFor repository repodir >>= read_repo
>    us <- read_repo repository
>    common :>> us' <- return $ findCommonWithThem us them
>    prePushChatter opts us (reverseFL us') them
Same here.

Yours,
   Petr.

Thanks for the remark Petr. Here is a version that does not have the
bad side effect. I have tested it agains bogus repos addresses and
they do not get added to _darcs/prefs/repos .

guillaume

1 patch for repository http://darcs.net:

Tue May 18 17:42:33 CEST 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away

Attachments

• resolve-issue1784_-push-and-pull-print-remote-address-right-away.dpatch
• unnamed

May I send this back your way, Petr?

On Tue, May 18, 2010 at 16:00:20 +0000, Guillaume Hoffmann wrote:
> Thanks for the remark Petr. Here is a version that does not have the
> bad side effect. I have tested it agains bogus repos addresses and
> they do not get added to _darcs/prefs/repos .

Looks good, thanks to Petr for the earlier skim.

Guillaume: send may be another one.  Perhaps get too.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-bb225a25d02d67fd7a9ff859460d24d725d92745

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-bb225a25d02d67fd7a9ff859460d24d725d92745