* remove get --ephemeral support

This patch removes support for get --ephemeral.

Currently, getting a repository with --ephemeral yields a broken
repository (it is impossible to do a darcs whatsnew inside it for
instance). This flag is hardly documented anywhere and seems superseeded
by the --lazy flag. Hence the removal.

* remove support for get --partial and check --partial

This patch removes support for checkpoints.
Checkpoints are a feature of old-fashioned repositories that make
getting faster. In modern repositories they no longer exist, and
get --lazy is recommended to get a similar effect.

Checkpoint creation has already been removed from the Darcs codebase
since a while.
What the present patch removes is the following set of commands:

get --partial
check --partial
check --complete (no longer makes sense now)

With this patch, Darcs just ignores checkpoints, so it always gets
and checks completely OF repositories.

Removing this code is a baby step towards old-fashioned support removal.

However in Darcs.Commands.Optimize, I left the lines that detect
and remove the "checkpoints" subdir in the function that upgrades
repos from old-fashined to Hashed, so checkpoints are still cleaned
when upgrading.

4 patches for repository http://darcs.net:

Mon Nov  1 11:03:24 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove all tests related to checkpoints and --partial

Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove get --ephemeral support

Mon Nov  1 11:26:29 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove support for get --partial and check --partial

Mon Nov  1 11:30:30 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * fix warnings following --partial removal

Attachments

• remove-all-tests-related-to-checkpoints-and-__partial.dpatch
• unnamed

No opinions, at least on the patch that removes "get --ephemeral" ?

Having such a command that creates broken repositories does not look
very serious, unless I am not aware of a particuliar use that someone
may know about...

guillaume


2010/11/1 gh <bugs@darcs.net>:
>
> New submission from gh <guillaumh@gmail.com>:
>
> * remove get --ephemeral support
>
> This patch removes support for get --ephemeral.
>
> Currently, getting a repository with --ephemeral yields a broken
> repository (it is impossible to do a darcs whatsnew inside it for
> instance). This flag is hardly documented anywhere and seems superseeded
> by the --lazy flag. Hence the removal.
>
> * remove support for get --partial and check --partial
>
> This patch removes support for checkpoints.
> Checkpoints are a feature of old-fashioned repositories that make
> getting faster. In modern repositories they no longer exist, and
> get --lazy is recommended to get a similar effect.
>
> Checkpoint creation has already been removed from the Darcs codebase
> since a while.
> What the present patch removes is the following set of commands:
>
> get --partial
> check --partial
> check --complete (no longer makes sense now)
>
> With this patch, Darcs just ignores checkpoints, so it always gets
> and checks completely OF repositories.
>
> Removing this code is a baby step towards old-fashioned support removal.
>
> However in Darcs.Commands.Optimize, I left the lines that detect
> and remove the "checkpoints" subdir in the function that upgrades
> repos from old-fashined to Hashed, so checkpoints are still cleaned
> when upgrading.
>
> 4 patches for repository http://darcs.net:
>
> Mon Nov  1 11:03:24 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>  * remove all tests related to checkpoints and --partial
>
> Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>  * remove get --ephemeral support
>
> Mon Nov  1 11:26:29 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>  * remove support for get --partial and check --partial
>
> Mon Nov  1 11:30:30 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>  * fix warnings following --partial removal
>
> ----------
> files: remove-all-tests-related-to-checkpoints-and-__partial.dpatch, unnamed
> messages: 12860
> nosy: gh
> status: needs-screening
> title: remove all tests related to checkpoints ... (and 3 more)
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch442>
> __________________________________

Op zaterdag 06 november 2010 17:58 schreef gh:
> gh <guillaumh@gmail.com> added the comment:
> 
> No opinions, at least on the patch that removes "get --ephemeral" ?

My opinion on the idea of removing these features is "good riddance".

I didn't review the patches in-depth, but it surprises me a bit that you have one patch to remove --partial that also removes Checkpoint.hs, and then another patch to fix the warnings. I'd have recorded one patch to remove the --partial flag without introducing warnings, and another to remove Checkpoint.hs.

This conflicts with screened, can you amend (using Reinier's suggestion)? 
I agree with him on 'good riddance'

Patches have been already sent to bugs@darcs.net and will probably
appear today on the list (it seems there's a 24h delay these days).

2010/11/9 Florent Becker <bugs@darcs.net>:
>
> Florent Becker <florent.becker@ens-lyon.org> added the comment:
>
> This conflicts with screened, can you amend (using Reinier's suggestion)?
> I agree with him on 'good riddance'
>
> ----------
> status: needs-screening -> followup-requested
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch442>
> __________________________________
>

Well I should have done that in my previous mail. Attached are the
patches that apply cleany to screened.
Sorry for the multiple posts.

2010/11/9 Guillaume Hoffmann <guillaumh@gmail.com>:
> Patches have been already sent to bugs@darcs.net and will probably
> appear today on the list (it seems there's a 24h delay these days).
>
> 2010/11/9 Florent Becker <bugs@darcs.net>:
>>
>> Florent Becker <florent.becker@ens-lyon.org> added the comment:
>>
>> This conflicts with screened, can you amend (using Reinier's suggestion)?
>> I agree with him on 'good riddance'
>>
>> ----------
>> status: needs-screening -> followup-requested
>>
>> __________________________________
>> Darcs bug tracker <bugs@darcs.net>
>> <http://bugs.darcs.net/patch442>
>> __________________________________
>>
>

Attachments

• remove-all-tests-related-to-checkpoints-and-__partial.dpatch

This new bundle applies cleanly on current screened. I also followed your
advice, Reinier.

4 patches for repository http://darcs.net/screened:

Mon Nov  1 11:03:24 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove all tests related to checkpoints and --partial

Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove get --ephemeral support

Mon Nov  8 20:11:37 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove support for get --partial and check --partial

Mon Nov  8 20:13:10 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove Darcs.Repository.Checkpoint

Attachments

• remove-all-tests-related-to-checkpoints-and-__partial.dpatch
• unnamed

On Tue, Nov 09, 2010 at 16:44:58 +0000, gh wrote:
> Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * remove get --ephemeral support

Good riddance on get --ephemeral

> Mon Nov  8 20:11:37 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * remove support for get --partial and check --partial
> 
> Mon Nov  8 20:13:10 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>   * remove Darcs.Repository.Checkpoint

Warning: forcing a complete get could break getting repositories which
were themselves --partial gets of another repo.  Is this something we're
willing to live with?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, try +44 (0)1273 64 2905 or
xmpp:kowey@jabber.fr (Jabber or Google Talk only)

>> Mon Nov  8 20:11:37 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>>   * remove support for get --partial and check --partial
>>
>> Mon Nov  8 20:13:10 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
>>   * remove Darcs.Repository.Checkpoint
>
> Warning: forcing a complete get could break getting repositories which
> were themselves --partial gets of another repo.  Is this something we're
> willing to live with?

Ah, interesting.

I'm inclined towards "let's live with it". Such a situation would
probably make some users nervous, but there should be some repository,
typically the public one of a project that promotes the use of
--partial, where the whole history would be available. For instance
the cabal project uses OF repositories with checkpoints
http://www.haskell.org/cabal/code.html , but they also contain the
whole history of the project and can be ``get`` completely again.

Guillaume

>
> --
> Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
> For a faster response, try +44 (0)1273 64 2905 or
> xmpp:kowey@jabber.fr (Jabber or Google Talk only)
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkzhO8MACgkQBUrOwgisBPn+AgCfft3+pexL4792uexdgL3cPrlG
> zksAn229PcJy1Da/dYNwjT8EMhH9+d7K
> =VnJS
> -----END PGP SIGNATURE-----
>
>

Also, does patch456 make this obsolete?

> Also, does patch456 make this obsolete?

As I answered on IRC: no, patch456 is a mistake from me.

What about this bundle? The patch removing ``get --ephemeral`` seems
to pose no problem, now we need to decide whether to remove support
for getting checkpoints.

Guillaume

This applies cleanly against current screened branch.

4 patches for repository http://darcs.net/screened/:

Mon Nov  1 11:03:24 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove all tests related to checkpoints and --partial

Mon Nov  1 11:16:02 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove get --ephemeral support

Wed Dec  8 19:38:13 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove support for get --partial and check --partial

Wed Dec  8 19:39:13 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove Darcs.Repository.Checkpoint

Attachments

• remove-all-tests-related-to-checkpoints-and-__partial.dpatch
• unnamed

Looks fine. Just a bunch of code and tests removal and collapsing of code 
where it's conditional on Partial.

This patch bundle (with 57 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-436b38aab404f7d84e6b25000fa60a0eea799168

This patch bundle (with 57 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-436b38aab404f7d84e6b25000fa60a0eea799168