Patch 459: remove unused getRepoPop function (and 6 more) - Darcs bug tracker

Title	remove unused getRepoPop function (and 6 more)
Superseder		Nosy List	galbolle, ganesh, gh
Related Issues
Status	accepted	Assigned To	ganesh
Milestone

Created on 2010-11-10.10:02:04 by gh, last changed 2011-05-10.20:06:57 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
remove-unused-getrepopop-function.dpatch		gh, 2010-11-10.10:02:04	text/x-darcs-patch
unnamed		gh, 2010-11-10.10:02:04

See mailing list archives for discussion on individual patches.

Messages
msg12982 (view)	Author: gh	Date: 2010-11-10.10:02:04
This is more or less a followup bundle to patch442. Among Florent's suggestions were: * the removal of the nopristine = NoPristine function * fixing the bug strings in Darcs.Repository.Pristine * writing haddocks for some functions in this module (I wrote just two miserable haddock lines) So this bundle focusses on the Darcs.Repository.Pristine module. There are some contigent patches that do some cleanup on unused stuff. The last patch removes the command darcs optimize --relink-pristine. The reason for this removal is that this command is said to be not recommended to use, it only works on OF repositories and there is no test for it. Removing it enables to remove yet another function in D.R.P . 7 patches for repository http://darcs.net: Tue Nov 9 19:18:44 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * remove unused getRepoPop function Tue Nov 9 17:37:51 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * remove the nopristine function Tue Nov 9 19:47:33 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * unused return value of createPristine Wed Nov 10 09:47:35 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * remove dangling doc paragraph from 2002 in DarcsRepo Wed Nov 10 09:50:28 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * in Pristine use bug more and remove unused functions Wed Nov 10 10:06:45 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * haddock for createPartialsPristineDirectoryTree Wed Nov 10 10:21:22 CET 2010 Guillaume Hoffmann <guillaumh@gmail.com> * remove command optimize --relink-pristine Attachments remove-unused-getrepopop-function.dpatch unnamed
msg13178 (view)	Author: ganesh	Date: 2010-11-21.20:33:00
Grabbing this as it's been sitting around for a while. Looks good. I agree about removing --relink-pristine. I think the newer cache machinery is a good alternative (on hashed repos) anyway.
msg13183 (view)	Author: darcswatch	Date: 2010-11-21.21:12:13
This patch bundle (with 9 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-9e91e0052bac55771b0c193bb66b5d2bf60a4723
msg14262 (view)	Author: darcswatch	Date: 2011-05-10.20:06:57
This patch bundle (with 9 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-9e91e0052bac55771b0c193bb66b5d2bf60a4723

History
Date	User	Action	Args
2010-11-10 10:02:04	gh	create
2010-11-10 10:30:40	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-9e91e0052bac55771b0c193bb66b5d2bf60a4723
2010-11-17 12:50:01	galbolle	set	assignedto: galbolle nosy: + galbolle
2010-11-21 20:33:00	ganesh	set	status: needs-screening -> accepted-pending-tests assignedto: galbolle -> ganesh messages: + msg13178 nosy: + ganesh
2010-11-21 21:12:13	darcswatch	set	status: accepted-pending-tests -> accepted messages: + msg13183
2011-05-10 20:06:57	darcswatch	set	messages: + msg14262