looks good, thanks! I've pushed all to screened and the ones that aren't 
blocked to unstable.

Minor comments which you or I could address in a followup patch:

There's end-of-line whitespace in one line of the speedyCommute patch

I don't find the comment "'p2 == AddDir' is omitted since it is 
unuseful" very clear - it's not obvious to a casual reader why that 
particular condition is important in the first place.

On Fri, Dec 17, 2010 at 10:44 PM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> New submission from Ganesh Sittampalam <ganesh@earth.li>:
>
> looks good, thanks! I've pushed all to screened and the ones that aren't
> blocked to unstable.
>
> Minor comments which you or I could address in a followup patch:
>
> There's end-of-line whitespace in one line of the speedyCommute patch
>
Sorry, I will be more careful with that.

>
> I don't find the comment "'p2 == AddDir' is omitted since it is
> unuseful" very clear - it's not obvious to a casual reader why that
> particular condition is important in the first place.
>
I will try to clarify it in following patches, maybe saying something like
-- the exact guard is p2 == AddDir && d == d2
-- but d == d2 suffices because we known p2 != RmDir since patches must be
sequential.

>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch500>
> __________________________________
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-devel
>

Attachments

• unnamed

Dependencies are in darcs.net, and quickchecks pass ok, pushing the 2
missing patches.