darcs

Patch 556 New Prim generators and related properties

Title New Prim generators and related properties
Superseder Nosy List ganesh, iago
Related Issues
Status accepted Assigned To ganesh
Milestone

Created on 2011-02-16.20:24:09 by iago, last changed 2011-05-10.22:06:35 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
add-invert-rollback-and-effect-preserving-properties-without-conflicts iago, 2011-02-20.01:06:19 application/octet-stream
improved-prim-generators-and-properties.dpatch iago, 2011-02-16.20:24:09 application/octet-stream
unnamed iago, 2011-02-20.01:06:19 text/html
See mailing list archives for discussion on individual patches.
Messages
msg13694 (view) Author: iago Date: 2011-02-16.20:24:09
Some code duplication will be removed later.
It also introduces some minor fixes.
Attachments
msg13706 (view) Author: ganesh Date: 2011-02-20.00:16:15
Sorry, looks like this got overtaken by other changes to screened. Could 
you resolve the conflicts and submit again? (Either record a conflict 
resolution patch or amend-record this one, whichever's easier for you)
msg13708 (view) Author: iago Date: 2011-02-20.01:06:19
Resolved.

On Sun, Feb 20, 2011 at 12:16 AM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> Sorry, looks like this got overtaken by other changes to screened. Could
> you resolve the conflicts and submit again? (Either record a conflict
> resolution patch or amend-record this one, whichever's easier for you)
>
> ----------
> assignedto:  -> iago
> status: needs-screening -> followup-requested
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch556>
> __________________________________
>



-- 
Iago Abal Rivas
Attachments
msg13710 (view) Author: ganesh Date: 2011-02-20.17:11:08
pushed to screened now
msg13870 (view) Author: ganesh Date: 2011-04-02.10:36:55
Looks fine - this quite a casual review since

(a) this is "just" testing code
(b) it's building on a very messy base anyway
(c) I've had extensive IRC discussions with Iago about what he's doing 
in general
History
Date User Action Args
2011-02-16 20:24:09iagocreate
2011-02-20 00:16:16ganeshsetstatus: needs-screening -> followup-requested
assignedto: iago
messages: + msg13706
2011-02-20 01:06:19iagosetfiles: + unnamed, add-invert-rollback-and-effect-preserving-properties-without-conflicts
messages: + msg13708
2011-02-20 17:11:08ganeshsetstatus: followup-requested -> needs-review
messages: + msg13710
2011-02-20 17:11:19ganeshsetassignedto: iago -> ganesh
nosy: + ganesh
2011-03-09 18:36:08darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a7472c9b7275ac421067a3328ff69bbffb0f1c1f
2011-04-02 10:36:55ganeshsetstatus: needs-review -> accepted
messages: + msg13870
2011-05-10 22:06:35darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a7472c9b7275ac421067a3328ff69bbffb0f1c1f -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-a7472c9b7275ac421067a3328ff69bbffb0f1c1f