Apply the proposed style guide to the export list in Darcs.Patch

1 patch for repository http://darcs.net:

Sat Jan 28 23:37:56 EST 2012  Will Langstroth <will@langstroth.com>
  * Organize export list in Darcs.Patch

Attachments

• organize-export-list-in-darcs_patch.dpatch
• patch-preview.txt
• unnamed

This one conflicts with a previous submission (that's now in screened) - 
would you mind resubmitting?

Should be better now.

1 patch for repository http://darcs.net:

Mon Jan 30 20:09:43 EST 2012  Will Langstroth <will@langstroth.com>
  * [patch708] resubmission

Attachments

• _patch708_-resubmission.dpatch
• patch-preview.txt
• unnamed

Sorry, only just noticed: now the patch comment is rather odd - it's "
[patch708] resubmission" rather than "Organize export list in 
Darcs.Patch". OK for me to change it back?

Please do. That's me getting used to the workflow.

On 14 February 2012 14:35, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh@earth.li> added the comment:
>
> Sorry, only just noticed: now the patch comment is rather odd - it's "
> [patch708] resubmission" rather than "Organize export list in
> Darcs.Patch". OK for me to change it back?
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch708>
> __________________________________
>

Attachments

• unnamed

Patch amended with correct message

1 patch for repository /home/ganesh/darcs/darcs-temp:

Tue Feb 14 20:25:20 GMT 2012  Will Langstroth <will@langstroth.com>
  * Organize export list in Darcs.Patch

Attachments

• organize-export-list-in-darcs_patch.dpatch
• patch-preview.txt
• unnamed

Thanks for the style clean up.

> +      -- * for PatchTest

Capitalizing the first letter of these Haddock comments seems to be the 
standard.

> +import Darcs.Patch.Apply ( applyToFilePaths, effectOnFilePaths, 
applyToTree )
> +import Darcs.Patch.Apply ( ApplyState )

These two imports could be combined, I suppose.

The rest of the patch looks good and the above comments are only minor. Dear committers, please push this patch.

On 13 March 2012 22:22, Michael Hendricks <bugs@darcs.net> wrote:
>> +import Darcs.Patch.Apply ( applyToFilePaths, effectOnFilePaths,
>applyToTree )
>> +import Darcs.Patch.Apply ( ApplyState )
>
>These two imports could be combined, I suppose.

That's something else I do with these clean-up patches - check the compile
output (ideally, there shouldn't be any!), and also run hlint over the
files in
question(I'm pretty sure it would have picked up this multiple-import case).

Owen.

Attachments

• unnamed

>
> That's something else I do with these clean-up patches - check the compile
> output (ideally, there shouldn't be any!), and also run hlint over the
> files in
> question(I'm pretty sure it would have picked up this multiple-import
> case).


Fair point. I'm not very concerned, though, because I run the full test
suite before sending a patch. "First, do no harm" as the saying goes. But
yes, hlint is a good idea.

Attachments

• unnamed