darcs

Patch 712 Refactor: Use list comprehension instead... (and 4 more)

Title Refactor: Use list comprehension instead... (and 4 more)
Superseder Nosy List stulli
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-01-30.22:39:59 by stulli, last changed 2012-03-14.15:44:43 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
refactor_-use-list-comprehension-instead-of-recursion.dpatch stulli, 2012-01-30.22:39:59 text/x-darcs-patch
unnamed stulli, 2012-01-30.22:39:59
See mailing list archives for discussion on individual patches.
Messages
msg15076 (view) Author: stulli Date: 2012-01-30.22:39:59
Refactoring Dist.hs for hopefully better comprehensibility.

5 patches for repository http://darcs.net/screened:

Mon Jan 30 22:23:11 CET 2012  Andreas Brandt <andreas.brandt.de@googlemail.com>
  * Refactor: Use list comprehension instead of recursion

Mon Jan 30 23:03:25 CET 2012  Andreas Brandt <andreas.brandt.de@googlemail.com>
  * Refactor: Use takeFileName instead of own function
  Since getCurrentDirectory always gives an absolute path the check for '/'
  is not necessary and takeFileName can do the job.

Mon Jan 30 23:04:55 CET 2012  Andreas Brandt <andreas.brandt.de@googlemail.com>
  * Fix import of System.FilePath
  To quote the documentation of System.FilePath.Posix:
  "Importing System.FilePath is usually better."

Mon Jan 30 23:10:44 CET 2012  Andreas Brandt <andreas.brandt.de@googlemail.com>
  * Removed unnecessary whitespace/comment

Mon Jan 30 23:27:31 CET 2012  Andreas Brandt <andreas.brandt.de@googlemail.com>
  * Pull getDistName out of IO
Attachments
msg15083 (view) Author: darcswatch Date: 2012-01-31.19:24:48
This patch bundle (with 5 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-610e05514550aa06376d540729d81598bde457e6
msg15090 (view) Author: kowey Date: 2012-02-04.10:46:45
Whoops, I see we've screened this whole bundle.  We may need to rollback 
the patch that switches from System.FilePath.Posix see patch716 unless 
we've already switched to AnchoredPath completely and I'm just being 
stupid.
msg15183 (view) Author: stulli Date: 2012-02-27.18:35:12
I fixed the FilePath issue with this patch: http://bugs.darcs.net/patch725
msg15313 (view) Author: gh Date: 2012-03-14.15:26:17
Looks good, pushing it with patch725.
msg15315 (view) Author: darcswatch Date: 2012-03-14.15:44:43
This patch bundle (with 5 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-610e05514550aa06376d540729d81598bde457e6
History
Date User Action Args
2012-01-30 22:39:59stullicreate
2012-01-30 22:41:08darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-610e05514550aa06376d540729d81598bde457e6
2012-01-31 19:24:48darcswatchsetstatus: needs-screening -> needs-review
messages: + msg15083
2012-02-04 10:46:45koweysetmessages: + msg15090
2012-02-27 18:35:13stullisetmessages: + msg15183
2012-03-14 15:26:17ghsetstatus: needs-review -> accepted
messages: + msg15313
2012-03-14 15:44:43darcswatchsetmessages: + msg15315