darcs

Patch 753 Son of Remove Function Delimiters

Title Son of Remove Function Delimiters
Superseder Nosy List wlangstroth
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-03-12.23:27:50 by wlangstroth, last changed 2012-03-31.01:32:10 by gh.

Files
File name Status Uploaded Type Edit Remove
_patch753_-son-of-remove-function-delimiters.dpatch wlangstroth, 2012-03-17.21:03:44 application/x-darcs-patch
patch-preview.txt wlangstroth, 2012-03-17.21:03:44 text/x-darcs-patch
patch-preview.txt gh, 2012-03-22.18:12:09 text/x-darcs-patch
remove-the-function-delimiters.dpatch gh, 2012-03-22.18:12:09 application/x-darcs-patch
unnamed wlangstroth, 2012-03-17.14:48:24 text/html
unnamed wlangstroth, 2012-03-17.21:03:44
unnamed wlangstroth, 2012-03-19.15:50:42 text/html
unnamed gh, 2012-03-22.18:12:09
See mailing list archives for discussion on individual patches.
Messages
msg15285 (view) Author: wlangstroth Date: 2012-03-12.23:27:50
1 patch for repository http://darcs.net:

Mon Mar 12 19:25:06 EDT 2012  Will Langstroth <will@langstroth.com>
  * Remove the function delimiters
  find . -name '*.hs' | xargs -n 2 -I {} sed -i -e '/^------------------------------------------------------------------------------/d' {}
  Easiest negative commit ever. When my other patches get commited, I'll do that again, and the repo will once again be function delimiter free.
Attachments
msg15350 (view) Author: gh Date: 2012-03-16.23:16:39
This patch now conflicts with the screened repository, could you send it
again?

Also, how do you make sure you don't delete lines that were in the code
before your patch? Or do we always want to remove them?
msg15352 (view) Author: wlangstroth Date: 2012-03-17.14:48:24
I can do it again, pretty easily (see the comment on the commit). There
aren't that many examples of "dashed lines" in the code, and only the files
I altered have ones longer than 70 dashes long. I guess "grep" is the short
answer.

On 16 March 2012 19:16, Guillaume Hoffmann <bugs@darcs.net> wrote:

>
> Guillaume Hoffmann <guillaumh@gmail.com> added the comment:
>
> This patch now conflicts with the screened repository, could you send it
> again?
>
> Also, how do you make sure you don't delete lines that were in the code
> before your patch? Or do we always want to remove them?
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch753>
> __________________________________
>
Attachments
msg15353 (view) Author: wlangstroth Date: 2012-03-17.21:03:44
1 patch for repository http://darcs.net:

Sat Mar 17 17:01:07 EDT 2012  Will Langstroth <will@langstroth.com>
  * [patch753] Son of Remove Function Delimiters
Attachments
msg15355 (view) Author: gh Date: 2012-03-19.15:34:25
Try again without putting the patch number into the patch name :-)
msg15356 (view) Author: wlangstroth Date: 2012-03-19.15:50:42
Sigh. Here I thought I was doing it the right way. Roger; wilco.

On 19 March 2012 11:34, Guillaume Hoffmann <bugs@darcs.net> wrote:

>
> Guillaume Hoffmann <guillaumh@gmail.com> added the comment:
>
> Try again without putting the patch number into the patch name :-)
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch753>
> __________________________________
>
Attachments
msg15381 (view) Author: gh Date: 2012-03-22.18:12:09
Thanks Will. I'm screening this right away to prevent conflicts.

1 patch for repository http://darcs.net:

Thu Mar 22 15:00:12 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * Remove the function delimiters
  Initial patch by Will Langstroth.
Attachments
msg15386 (view) Author: mndrix Date: 2012-03-23.21:08:51
Looks good.  Committers, please push this patch.
History
Date User Action Args
2012-03-12 23:27:50wlangstrothcreate
2012-03-16 23:16:39ghsetmessages: + msg15350
2012-03-17 14:48:24wlangstrothsetfiles: + unnamed
messages: + msg15352
2012-03-17 21:03:44wlangstrothsetfiles: + patch-preview.txt, _patch753_-son-of-remove-function-delimiters.dpatch, unnamed
messages: + msg15353
title: Remove the function delimiters -> Son of Remove Function Delimiters
2012-03-17 21:04:33wlangstrothsetfiles: - patch-preview.txt
2012-03-17 21:04:42wlangstrothsetfiles: - unnamed
2012-03-17 21:04:48wlangstrothsetfiles: - remove-the-function-delimiters.dpatch
2012-03-19 15:34:25ghsetmessages: + msg15355
2012-03-19 15:50:43wlangstrothsetfiles: + unnamed
messages: + msg15356
2012-03-22 18:12:09ghsetfiles: + patch-preview.txt, remove-the-function-delimiters.dpatch, unnamed
messages: + msg15381
2012-03-22 18:13:34ghsetstatus: needs-screening -> needs-review
2012-03-23 21:08:51mndrixsetstatus: needs-review -> accepted-pending-tests
messages: + msg15386
2012-03-31 01:32:10ghsetstatus: accepted-pending-tests -> accepted