Patch 985: resolve issue2238: let optsModifier remove all occurre... - Darcs bug tracker

Title	resolve issue2238: let optsModifier remove all occurre...
Superseder		Nosy List	gpiero
Related Issues
Status	accepted	Assigned To	gpiero
Milestone

Created on 2012-12-16.18:33:55 by gpiero, last changed 2012-12-21.10:03:02 by owst.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		gpiero, 2012-12-16.18:33:55	text/x-darcs-patch
patch-preview.txt		gpiero, 2012-12-17.07:01:26	text/x-darcs-patch
resolve-issue2238_-let-optsmodifier-remove-all-occurrences-of-lookforadds.dpatch		gpiero, 2012-12-16.18:33:55	application/x-darcs-patch
resolve-issue2238_-let-optsmodifier-remove-all-occurrences-of-lookforadds.dpatch		gpiero, 2012-12-17.07:01:27	application/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg16415 (view)	Author: gpiero	Date: 2012-12-16.18:33:55
1 patch for repository http://darcs.net: Sat Dec 15 12:08:06 CET 2012 "Gian Piero Carrubba" <gpiero@rm-rf.it> * resolve issue2238: let optsModifier remove all occurrences of LookForAdds Attachments patch-preview.txt resolve-issue2238_-let-optsmodifier-remove-all-occurrences-of-lookforadds.dpatch
msg16416 (view)	Author: owst	Date: 2012-12-16.20:08:18
Looks good, though we could probably get rid of the import of Data.List for filter, since it's in the Prelude and imported by default anyway. gpiero, please can you send a follow-up, amended patch, without the Data.List import, thanks.
msg16419 (view)	Author: gpiero	Date: 2012-12-17.07:01:27
1 patch for repository http://darcs.net: Sun Dec 16 21:47:18 CET 2012 "Gian Piero Carrubba" <gpiero@rm-rf.it> * resolve issue2238: let optsModifier remove all occurrences of LookForAdds Amended patch: remove the now useless import from Data.List as pointed out by owst Hoping I got right the 'how to send an amended patch' stuff... Attachments patch-preview.txt resolve-issue2238_-let-optsmodifier-remove-all-occurrences-of-lookforadds.dpatch
msg16436 (view)	Author: owst	Date: 2012-12-18.13:41:24
Thanks for sending a follow-up gpiero! Anyone who has permissions can now push this to reviewed (I'm at work, without the right SSH key)
msg16449 (view)	Author: owst	Date: 2012-12-21.10:03:02
I've just pushed this patch to screened & reviewed. Thanks!

History
Date	User	Action	Args
2012-12-16 18:33:55	gpiero	create
2012-12-16 20:08:18	owst	set	status: needs-screening -> followup-requested assignedto: gpiero messages: + msg16416
2012-12-17 07:01:27	gpiero	set	files: + patch-preview.txt, resolve-issue2238_-let-optsmodifier-remove-all-occurrences-of-lookforadds.dpatch messages: + msg16419
2012-12-18 13:41:25	owst	set	status: followup-requested -> needs-screening messages: + msg16436
2012-12-21 10:03:02	owst	set	status: needs-screening -> accepted messages: + msg16449