If you hit "v" it displays trailing whitespace like this " [_$_]".

When you hit "p" it doesn't.  It ought!

This is under cygniw bash with rxvt.

Regards,

Zooko

On Wed, Jan 25, 2006 at 07:17:43PM +0000, Zooko wrote:
> If you hit "v" it displays trailing whitespace like this " [_$_]".
> 
> When you hit "p" it doesn't.  It ought!

I agree.  At the same time, this should be configurable, since some pagers
won't be happy with ansi color codes, but other will.  Which means
documentation-writing for somebody...
-- 
David Roundy
http://www.darcs.net

> > If you hit "v" it displays trailing whitespace like this " [_$_]".
> > When you hit "p" it doesn't.  It ought!
> 
> I agree.  At the same time, this should be configurable, since some pagers
> won't be happy with ansi color codes, but other will.  Which means
> documentation-writing for somebody...

Isn't it already configured by DARCS_ALWAYS_COLOR?

I think it is a simple matter of making 'p' do the same thing that 'v' does,
then?

Regards,

Zooko

On Wed, Feb 01, 2006 at 11:34:25AM -0400, zooko@zooko.com wrote:
> 
> > > > > If you hit "v" it displays trailing whitespace like this "
> > > > > [_$_]".  When you hit "p" it doesn't.  It ought!
> > > > 
> > > > I agree.  At the same time, this should be configurable, since some
> > > > pagers won't be happy with ansi color codes, but other will.  Which
> > > > means documentation-writing for somebody...
> > > 
> > > Isn't it already configured by DARCS_ALWAYS_COLOR?
> > > 
> > > I think it is a simple matter of making 'p' do the same thing that
> > > 'v' does, then?
> > 
> > I am not sure how we should interpret DARCS_ALWAYS_COLOR.  Depending on
> > your pager settings, you may or may not see garbage when using ansi
> > color codes.  I know my less is set up to work fine with color codes,
> > but I'm not sure that was the default.  So a separate "color pager"
> > flag might be worthwhile.
> 
> Did you mean to remove the issue tracker from the Cc: on this mail?

No, I didn't.  I just didn't notice that the tracker was being cc'ed rather
than sent to directly...

> less does not do this by default -- you have to give it the "-R" flag on the
> command-line or in the LESS environment variable, or in a "lesskey" file.
> 
> I don't understand the issue.  If the user sets DARCS_ALWAYS_COLOR to 1, then
> we should send color codes.  If the user sets DARCS_DONT_COLOR to 1 then we
> shouldn't.  If the user has set neither, then we should set it only if stdout
> is a tty which understands color codes.  Right?  How does the difference
> between 'v' and 'p' change this?

I guess that makes sense.  I had been interpreting DARCS_ALWAYS_COLOR to
mean "always color when writing to stdout", but you're right that this is
an artificial distinction.
-- 
David Roundy
http://www.darcs.net

Fixed by

Mon Mar 20 00:41:03 CET 2006  Tommy Pettersson <ptp@lysator.liu.se>
  * write with fancyPrinters to pager (issue108)

Please reopen if not convinced.

fixed in 1.0.7