Created on 2008-10-09.22:45:15 by dagit, last changed 2009-08-27.14:19:34 by admin.
msg6297 (view) |
Author: dagit |
Date: 2008-10-09.22:45:12 |
|
While it is very important for the development version of darcs, and darcs
developers to use -Werror, this flag can make building stable releases fail
spuriously.
For example, with ghc 6.10 several flags, such as -fffi, are now deprecated and
emit warnings. These warnings cause the compile to fail but are ignorable at
this time.
It seems prudent to remove -Werror from the makefile of stable releases. We
have tested the code and I believe it is fair to be optimistic about the
compilation options in this scenario.
I'm not sure how to best make this a reality in the stable releases. Maybe a
pre-hook in darcs dist?
|
msg6318 (view) |
Author: thorkilnaur |
Date: 2008-10-12.11:22:29 |
|
I am not completely in the picture, but I guess that the situation here is that some user has downloaded a source
distribution of darcs and then tries to build it? In that case, I suggest that, rather than leaving out any -Werror
flags, that some mechanism (a ./configure flag?) be added, if not already there, to allow building without the -
Werror flag. And that matters be arranged such that the error reported when building fails because of -Werror clearly
indicates this as the source of the trouble and mentions the ./configure flag to work around it.
Best regards Thorkil
|
msg6334 (view) |
Author: droundy |
Date: 2008-10-16.14:55:13 |
|
Good idea. This can easily be achieved in the make dist target of the makefile.
On the other hand, I'd rather delay these sorts of features until after we've
done the franchise transition.
David
|
msg6335 (view) |
Author: droundy |
Date: 2008-10-16.21:45:46 |
|
The following patch updated the status of issue1138 to be resolved:
* half-resolve issue1138: make it possible in setup.hs to not use -Werror.
Ignore-this: 4f4f31cf24e25774a8217c26813ddbd3
|
|
Date |
User |
Action |
Args |
2008-10-09 22:45:15 | dagit | create | |
2008-10-12 11:22:31 | thorkilnaur | set | nosy:
kowey, dagit, simon, thorkilnaur, dmitry.kurochkin messages:
+ msg6318 |
2008-10-16 14:55:17 | droundy | set | topic:
+ ProbablyEasy nosy:
+ droundy, jaredj messages:
+ msg6334 |
2008-10-16 21:45:48 | droundy | set | status: needs-reproduction -> resolved-in-unstable nosy:
droundy, kowey, dagit, simon, thorkilnaur, jaredj, dmitry.kurochkin messages:
+ msg6335 |
2009-04-22 03:36:50 | twb | set | status: resolved-in-unstable -> resolved nosy:
droundy, kowey, dagit, simon, thorkilnaur, jaredj, dmitry.kurochkin |
2009-08-06 18:01:17 | admin | set | nosy:
+ markstos, jast, Serware, darcs-devel, zooko, mornfall, tommy, beschmi, - droundy, jaredj |
2009-08-06 21:13:21 | admin | set | nosy:
- beschmi |
2009-08-10 21:49:44 | admin | set | nosy:
+ jaredj, - tommy, markstos, darcs-devel, zooko, jast, Serware, mornfall |
2009-08-10 23:48:00 | admin | set | nosy:
- dagit |
2009-08-25 17:30:52 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:19:34 | admin | set | nosy:
kowey, darcs-devel, thorkilnaur, jaredj, dmitry.kurochkin |
|