Issue 1984 Darcs convert with invalid repository name: poor error message

Title Darcs convert with invalid repository name: poor error message
Priority Status resolved
Milestone Resolved in 2.8.0
Superseder Nosy List dmitry.kurochkin, dmitry.tsygankov
Assigned To dmitry.tsygankov

Created on 2010-10-24.08:22:17 by dmitry.tsygankov, last changed 2010-11-02.23:25:21 by noreply.

msg12815 (view) Author: dmitry.tsygankov Date: 2010-10-24.08:22:16
Darcs convert, when supplied with a non-existent repository name, spits
out a pattern match failure instead of reporting the error properly:

$ /usr/bin/darcs --version
2.4.4 (release)
$ /usr/bin/darcs convert noname00.pas

darcs failed:  Pattern match failure in do expression at

I think I fixed this in one line of code, as the appropriate error
message was already there, going to submit a patch soon:

$ darcs --version (+ 277 patches)
$ darcs convert noname00.pas

darcs failed:  Not a repository: noname00.pas
(noname00.pas/_darcs/inventory: openBinaryFile: does not exist (No such
file or directory))

Note: I was expecting to find a _darcs/inventory file because I could
not find (or read) _darcs/format and assumed that the remote repository
is old-fashioned.
msg12886 (view) Author: noreply Date: 2010-11-02.23:25:21
The following patch sent by Dmitry Tsygankov <dmitry.tsygankov@gmail.com> updated issue issue1984 with
status=resolved;resolvedin=2.8.0 HEAD

* resolve issue1984: better error message for 'darcs convert' 
Ignore-this: 1e1112dba335510460cffd8c377fe776
Date User Action Args
2010-10-24 08:22:17dmitry.tsygankovcreate
2010-11-02 23:25:21noreplysetstatus: unknown -> resolved
messages: + msg12886
resolvedin: 2.8.0