Issue 2228 pager doesn't try to interpret colour control codes

Title pager doesn't try to interpret colour control codes
Priority Status resolved
Milestone Resolved in 2.10.0
Superseder Nosy List owst
Assigned To

Created on 2012-09-02.16:32:40 by owst, last changed 2012-09-29.22:22:15 by noreply.

msg16048 (view) Author: owst Date: 2012-09-02.16:32:39
1. Summarise the issue (what were doing, what went wrong?)

I have DARCS_ALWAYS_COLOR=1 exported. Viewing a patch in the pager
doesn't interpret the colour codes, e.g. by

    echo p | darcs cha -i

2. What behaviour were you expecting instead?

If the pager is less, darcs should pass the -R flag. (more interprets
colour codes by default, and I'm not sure about more.com. Obviously, we
shouldn't do this if the user has set a custom pager)

3. What darcs version are you using? (Try: darcs --exact-version) (release candidate 2)

strangely :-), although I have no doubt this is present in HEAD.

4. What operating system are you running?
Linux x86_64
msg16174 (view) Author: noreply Date: 2012-09-29.22:22:14
The following patch sent by Owen Stephens <darcs@owenstephens.co.uk> updated issue issue2228 with
status=resolved;resolvedin=2.10.0 HEAD

* resolve issue2228: calls to less include -R argument to interpret colour codes 
Ignore-this: aac6845e9319b912aaa56f4acf96073c
Date User Action Args
2012-09-02 16:32:40owstcreate
2012-09-29 22:22:15noreplysetstatus: unknown -> resolved
messages: + msg16174
resolvedin: 2.10.0