Issue 2449 test harness/shelly: need to handle mis-encoded/binary data

Title test harness/shelly: need to handle mis-encoded/binary data
Priority Status resolved
Milestone 2.12.0 Resolved in 2.12.0
Superseder Nosy List darcs-devel, ganesh, gh
Assigned To

Created on 2015-04-18.15:01:41 by gh, last changed 2015-05-04.15:20:53 by noreply.

msg18374 (view) Author: gh Date: 2015-04-18.15:01:40
Split from discussion about http://bugs.darcs.net/patch1245

This is a bug from shelly, we will have to way for a fix and then
probably bump the dependency.

Relevant bit (reported by Ganesh):

> In general failing tests are properly reported, but two tests in
> particular start failing silently (whereas they were passing
> before the switch). The two tests are emailformat.sh and
> latin9-input.sh and it turns out that the test harness itself
> is throwing something like "fd:25: hGetLine: invalid argument
> (invalid byte sequence)", which explains the lack of output.

See https://github.com/yesodweb/Shelly.hs/issues/96
msg18390 (view) Author: noreply Date: 2015-05-04.15:20:52
The following patch sent by Ganesh Sittampalam <ganesh@earth.li> updated issue issue2449 with
status=resolved;resolvedin=2.12.0 HEAD

* resolve issue2449: use new hook in shelly to handle test output as binary 
Ignore-this: 975b7509921dcb8fb8119748b420588a
Date User Action Args
2015-04-18 15:01:41ghcreate
2015-04-18 17:39:22ghsetmilestone: 2.10.0 -> 2.12.0
2015-05-04 15:20:53noreplysetstatus: unknown -> resolved
messages: + msg18390
resolvedin: 2.12.0