The whole applyHunks/applyHunkLines business in
Darcs.Patch.Prim.V1.Apply (the only places that call
break{After,Before}NthNewline) should be documented, commented, and
probably refactored. breakAfterNthNewline and breakBeforeNthNewline
(from Darcs.Utils.ByteString) may end up moved to that module too.
I also hope we gain some performance on patch application by doing this.
(This is a followup from http://bugs.darcs.net/patch1406 ).
|