darcs

Issue 329 Clarify --ask-deps interface (Should aborting --ask-deps abort record?)

Title Clarify --ask-deps interface (Should aborting --ask-deps abort record?)
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, quick, thorkilnaur, tommy, trentbuck
Assigned To quick
Topics FauxBug

Created on 2006-11-01.16:36:00 by trentbuck, last changed 2009-08-27.14:11:15 by admin.

Messages
msg1164 (view) Author: twb Date: 2006-11-01.16:35:54
If you press `q' while selecting explicit deps, the patch is recorded
anyway.

    $ darcs --version
    1.0.8 (release)
    $ darcs --exact-version
    darcs compiled on Jul  4 2006, at 20:08:54
    # configured Fri Jun 16 14:55:21 EDT 2006
    ./configure --no-create --no-recursion

    Context:

    [TAG 1.0.8
    Tommy Pettersson <ptp@lysator.liu.se>**20060616160213]
    $ darcs init
    $ echo foo >foo
    $ darcs add foo
    $ darcs rec -am foo foo
    Recording changes in "foo":

    Finished recording patch 'foo'
    $ echo bar >bar
    $ darcs add bar
    $ darcs rec -am bar --ask-deps bar
    Recording changes in "bar":

    Thu Nov  2 03:31:47 EST 2006  Trent Buck <trentbuck@gmail.com>
      * foo
    Shall I depend on this patch? (1/?)  [ynWvpxqadjkc], or ? for help: q

    Depend on cancelled.
    Finished recording patch 'bar'
    $ darcs cha
    Thu Nov  2 03:32:09 EST 2006  Trent Buck <trentbuck@gmail.com>
      * bar

    Thu Nov  2 03:31:47 EST 2006  Trent Buck <trentbuck@gmail.com>
      * foo

I expected that the whole record operation to be aborted.

Is this the expected behaviour?  If so, what is the rationale for
behaving this way?
-- 
Trent Buck, Student Errant
msg1165 (view) Author: kowey Date: 2006-11-01.16:51:56
On Wed, Nov 01, 2006 at 16:36:00 +0000, Trent Buck wrote:
> If you press `q' while selecting explicit deps, the patch is recorded
> anyway.

Thanks for your reports :-)

I guess it brings up the question, in the ask-deps query, do we want 'q'
to just mean "abort deps" or "abort the whole record?" Both seem
reasonable to me.

Although, from issue308 the former seems to confuse users.
msg1895 (view) Author: kowey Date: 2007-07-23.06:05:46
Resolved in unstable with

Wed Jul 18 07:54:26 CEST 2007  Kevin Quick <quick@sparq.org>
  * Fix issue329: typing q for record --ask-deps records anyway with no deps.

Thanks!
History
Date User Action Args
2006-11-01 16:36:00trentbuckcreate
2006-11-01 16:52:04koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey, trentbuck
messages: + msg1165
2007-03-09 14:36:36koweysettopic: + FauxBug
nosy: + beschmi
title: Aborting --ask-deps does not abort the record -> Clarify --ask-deps UI
2007-03-09 14:37:51koweysetnosy: droundy, tommy, beschmi, kowey, trentbuck
title: Clarify --ask-deps UI -> Clarify --ask-deps interface (Should aborting --ask-deps abort record?)
2007-07-19 06:09:13koweysetnosy: + quick
2007-07-23 06:05:46koweysetstatus: unknown -> resolved-in-unstable
messages: + msg1895
2007-07-31 18:02:03koweysetstatus: resolved-in-unstable -> resolved-in-stable
2008-09-16 21:30:34adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:39:28adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, trentbuck, quick
2009-08-06 20:36:23adminsetnosy: - beschmi
2009-08-10 21:58:07adminsetnosy: + trentbuck, quick, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:57:35adminsetnosy: - dagit
2009-08-25 17:53:07adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:15adminsetnosy: tommy, kowey, darcs-devel, trentbuck, quick, thorkilnaur, dmitry.kurochkin