Created on 2007-01-12.11:22:58 by tim, last changed 2009-08-27.14:11:31 by admin.
msg1404 (view) |
Author: tim |
Date: 2007-01-12.11:22:24 |
|
Normally, when I record a patch, darcs prompts me to edit the long comment. I
did the following:
$ darcs record -m "Lightweight ticky-ticky profiling" ./compiler/cmm/CLabel.hs
./compiler/codeGen/CgClosure.lhs ./compiler/codeGen/CgTicky.hs
./compiler/codeGen/SMRep.lhs ./compiler/main/CodeOutput.lhs
./compiler/main/StaticFlags.hs ./includes/Cmm.h ./includes/README
./includes/Rts.h ./includes/StgTicky.h ./includes/TickyCounters.h
./includes/mkDerivedConstants.c ./rts/RtsStartup.c ./rts/StgMiscClosures.cmm
./rts/Ticky.c ./rts/Updates.cmm ./rts/Updates.h ./utils/genapply/GenApply.hs
Recording changes in "compiler/cmm/CLabel.hs" "compiler/codeGen/CgClosure.lhs"
"compiler/codeGen/CgTicky.hs" "compiler/codeGen/SMRep.lhs"
"compiler/main/CodeOutput.lhs" "compiler/main/StaticFlags.hs" "includes/Cmm.h"
"includes/README" "includes/Rts.h" "includes/StgTicky.h"
"includes/TickyCounters.h" "includes/mkDerivedConstants.c" "rts/RtsStartup.c"
"rts/StgMiscClosures.cmm" "rts/Ticky.c" "rts/Updates.cmm" "rts/Updates.h"
"utils/genapply/GenApply.hs":
hunk ./includes/StgTicky.h 1
[snip]
Shall I record this change? (1/?) [ynWsfqadjkc], or ? for help: a
Finished recording patch 'Lightweight ticky-ticky profiling'
krc@bongo:~/ghc-hacking$
I assume it must be because I supplied a file list that I didn't get prompted to
edit the long comment, and when I unrecorded the patch and re-recorded it with
--edit-long-comment, it worked, but this seems like a bug.
|
msg1412 (view) |
Author: kowey |
Date: 2007-01-12.22:07:27 |
|
No. When you pass a patch name via -m, you don't get the option to put
in a long comment. I think this behaviour is ok as-is.
That said, there is a --prompt-long-comment switch, but this also gets
ignored with -m. I think it would be fair to ask that
--prompt-long-comment with -m give the behaviour you're expecting.
|
msg2022 (view) |
Author: kowey |
Date: 2007-08-08.06:41:56 |
|
Resolved in unstable with:
Fri Jul 27 22:35:03 CEST 2007 Eric Kow <eric.kow@loria.fr>
* [issue389] Support record -m --prompt-long-comment.
|
|
Date |
User |
Action |
Args |
2007-01-12 11:22:58 | tim | create | |
2007-01-12 22:07:38 | kowey | set | priority: bug -> wishlist status: unread -> unknown messages:
+ msg1412 nosy:
droundy, tommy, beschmi, kowey, tim title: darcs record with file list doesn't prompt to edit long comment -> --prompt-long-comment should work with -m |
2007-07-22 07:43:45 | kowey | set | topic:
+ ProbablyEasy nosy:
droundy, tommy, beschmi, kowey, tim |
2007-08-08 06:41:57 | kowey | set | status: unknown -> resolved-in-unstable messages:
+ msg2022 |
2007-08-09 12:05:14 | kowey | set | status: resolved-in-unstable -> resolved-in-stable |
2008-09-16 21:30:48 | admin | set | status: resolved-in-stable -> resolved nosy:
+ dagit |
2009-08-06 17:40:50 | admin | set | nosy:
+ markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, tim |
2009-08-06 20:38:01 | admin | set | nosy:
- beschmi |
2009-08-10 22:00:52 | admin | set | nosy:
+ tim, - markstos, darcs-devel, zooko, jast, Serware, mornfall |
2009-08-10 23:59:02 | admin | set | nosy:
- dagit |
2009-08-25 17:54:23 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:11:31 | admin | set | nosy:
tommy, kowey, darcs-devel, tim, thorkilnaur, dmitry.kurochkin |
|