Using a umask of 077, darcs will still make scripts executable by all
users.  The following transcript demonstrates the problem:

$ cd `mktemp -d`
$ mkdir 1
$ cd 1
$ darcs init
$ cat >x
#!/bin/sh
true
$ darcs rec -lam x x
Recording changes in "x":

Finished recording patch 'x'
$ cd ..
$ umask 077
$ darcs get 1 2
Copying patch 1 of 1... done!
Finished getting.
$ ls -la 2
total 4
drwx------ 3 twb twb 27 2007-05-14 18:10 .
drwx------ 4 twb twb 22 2007-05-14 18:10 ..
drwx------ 7 twb twb 99 2007-05-14 18:10 _darcs
-rwx--x--x 1 twb twb 15 2007-05-14 18:10 x

Seems fair to say that it should not do this.

Note to anybody implementing this, however: --set-scripts-executable is
implemented in three places (I think), so you might want to refactor or something.

Trent,

Thanks for the report. Following the example shell scripts in the "tests"
directory from the darcs repo, would you be willing to turn your sequence of
example shell commands into a formal darcs automated test? It should hopefully
only take a few minutes, and would help move the bug fix process along. 

   Mark

On Thu, Jan 31, 2008 at 03:42:55AM -0000, Mark Stosberg wrote:
> Thanks for the report. Following the example shell scripts in the
> "tests" directory from the darcs repo, would you be willing to turn
> your sequence of example shell commands into a formal darcs
> automated test? It should hopefully only take a few minutes, and
> would help move the bug fix process along.

I'm only vaguely familiar with this process; nor do I generally work
directly with darcs' own darcs repo.  I can have a go (hopefully this
weekend) if you can point me to some documentation on creating test
cases that fit into the existing test infrastructure.

Trent,

With your exceptional shell skills, you'll do fine!

 darcs get --lazy (or --partial) --verbose http://darcs.net/repos/unstable 
 cd unstable/tests

 # Check out an example test script
 less obliterate.sh

 # Now, use it as a template for your new script
 cp obliterate.sh set_scripts_executable.sh
 
 # Hack on the script...then run it and see that it fails. 

 # Add the file, record the change and "darcs send". You're done!

You might also be interested to browse tests/shell_harness, which sets up the
environment that tests will run in, but that's not required to review.

Sat Feb  2 20:51:22 EST 2008  Trent W. Buck <twb@cyber.com.au>
  * Add functional sh test for issue458.

Attachments

• add-functional-sh-test-for-issue458_.dpatch
• unnamed

I've peer reviewed this test and moved it into the "./bugs" directory, since it
is currently failing.

The following patch updated the status of issue458 to be resolved in the unstable branch:

* resolved issue458: make setExecutable obey umask. 

You can view the patch details online here: 
http://darcs.net/cgi-bin/darcs.cgi/unstable/?c=annotate&p=20080215185218-72aca-a027f62d1aad6eeb49c346a04e927922f393cd5a.gz

With selinux, ls outputs "-rwx------." rather than "-rwx------" making 
this test fail.

Better to use grep than diff here I think.

Is it better to reopen, create a bug, or ?

This patch works for me on fedora 12:

--- darcs-2.4/tests/issue458.sh~	2010-02-27 04:10:08.000000000 +1000
+++ darcs-2.4/tests/issue458.sh	2010-03-01 14:52:54.000000000 +1000
@@ -20,9 +20,7 @@
 darcs record --repodir repo1 -lam x x
 umask 077                       # DENY ALL access to group, all
 darcs get --set-scripts-executable repo1 repo2
-ls -l repo2/x | cut -f 1 -d\  > mode
-echo -rwx------ > desired-mode
-diff -u desired-mode mode
+ls -l repo2/x | cut -f 1 -d\  | grep -- -rwx------
 
 cd ..
 rm -rf temp

Hi Jens, 

I'll just create a new ticket for this (new) issue

Yeah, I think it's generally better IMHO to open a new ticket for the
cases where we have something long dead which appears to come back as a
zombie [braaaiiins], as it may often be something completely unrelated.