Patch 187: Resolve issue1473: annotate command accepts "." and tr... - Darcs bug tracker

Title	Resolve issue1473: annotate command accepts "." and tr...
Superseder		Nosy List	StefanWehr, darcs-users, ganesh
Related Issues	darcs annotate --repodir /something '.' => no file or directory named '.' (2.2+) View: 1473
Status	accepted	Assigned To	ganesh
Milestone

Created on 2010-03-20.09:55:46 by StefanWehr, last changed 2011-05-10.20:35:40 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue1473_-annotate-command-accepts-___-and-treats-__-as-invalid-input.dpatch		StefanWehr, 2010-03-20.14:18:31	text/x-darcs-patch
unnamed		StefanWehr, 2010-03-20.09:55:45	text/plain
unnamed		StefanWehr, 2010-03-20.14:18:31	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg10308 (view)	Author: StefanWehr	Date: 2010-03-20.09:55:45
1 patch for repository http://darcs.net: Sat Mar 20 10:54:48 CET 2010 mail@stefanwehr.de * Resolve issue1473: annotate command accepts "." and treats "" as invalid input Attachments resolve-issue1473_-annotate-command-accepts-___-and-treats-__-as-invalid-input.dpatch unnamed
msg10313 (view)	Author: ganesh	Date: 2010-03-20.13:06:29
Before this patch, 'darcs annotate .' worked and 'darcs annotate -- repodir foo .' failed. After this patch, 'darcs annotate .' fails and 'darcs annotate --repodir foo .' works :-) Could you perhaps write tests for these two use cases? BTW if you use --subject '[patch187]' when submitting a new version it will get attached to this item in the tracker instead of making a new one.
msg10317 (view)	Author: StefanWehr	Date: 2010-03-20.14:18:31
1 patch for repository http://darcs.net: Sat Mar 20 15:17:18 CET 2010 mail@stefanwehr.de * Resolve issue1473: annotate command accepts "." and treats "" as invalid input Attachments resolve-issue1473_-annotate-command-accepts-___-and-treats-__-as-invalid-input.dpatch unnamed
msg10321 (view)	Author: ganesh	Date: 2010-03-20.15:03:59
Looks good, thanks. I'm going to push with the following trivial cleanup to the test script: Sat Mar 20 16:02:15 CET 2010 Ganesh Sittampalam <ganesh@earth.li> * use library function 'not' for checking failure hunk ./tests/issue1473.sh 35 -darcs annotate && exit 1 \|\| true -darcs annotate '' && exit 1 \|\| true +not darcs annotate +not darcs annotate '' hunk ./tests/issue1473.sh 41 -darcs annotate --repodir=R && exit 1 \|\| true -darcs annotate --repodir=R '' && exit 1 \|\| true +not darcs annotate --repodir=R +not darcs annotate --repodir=R ''
msg10333 (view)	Author: darcswatch	Date: 2010-03-20.17:26:02
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-efb39c47f558153899f8b73ddeaad9c269d5f0ff
msg14086 (view)	Author: darcswatch	Date: 2011-05-10.18:05:53
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-efb39c47f558153899f8b73ddeaad9c269d5f0ff

History
Date	User	Action	Args
2010-03-20 09:55:46	StefanWehr	create
2010-03-20 10:00:24	ganesh	link	patch183 superseder
2010-03-20 11:46:49	ganesh	set	nosy: + ganesh issues: + darcs annotate --repodir /something '.' => no file or directory named '.' (2.2+) assignedto: ganesh
2010-03-20 13:06:30	ganesh	set	status: needs-review -> followup-requested assignedto: ganesh -> StefanWehr messages: + msg10313
2010-03-20 14:18:32	StefanWehr	set	files: + resolve-issue1473_-annotate-command-accepts-___-and-treats-__-as-invalid-input.dpatch, unnamed messages: + msg10317
2010-03-20 14:54:16	ganesh	set	files: - resolve-issue1473_-annotate-command-accepts-___-and-treats-__-as-invalid-input.dpatch
2010-03-20 15:04:01	ganesh	set	status: followup-requested -> accepted-pending-tests assignedto: StefanWehr -> ganesh messages: + msg10321
2010-03-20 17:26:01	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a12379bf7b8a219da508d0cafda229cd2bc4d13c
2010-03-20 17:26:02	darcswatch	set	status: accepted-pending-tests -> accepted messages: + msg10333
2011-05-10 18:05:53	darcswatch	set	messages: + msg14086
2011-05-10 20:35:40	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-a12379bf7b8a219da508d0cafda229cd2bc4d13c -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-a12379bf7b8a219da508d0cafda229cd2bc4d13c