darcs

Patch 1987 tests: sort default-extensions (and 4 more)

Bug Tracker Home

Issues
Show Unassigned
 Show All
Search Issues

Patches
Show Open
 Show All
Search Patches

Login




Register
Lost your login?

Help
Roundup docs

Title tests: sort default-extensions (and 4 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-02-15.15:19:58 by ganesh, last changed 2020-06-20.08:38:08 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt ganesh, 2020-02-15.15:19:58 text/x-darcs-patch
patch-preview.txt ganesh, 2020-02-15.17:27:23 text/x-darcs-patch
tests_-nomonolocalbinds-needs-to-come-last.dpatch ganesh, 2020-02-15.17:27:23 application/x-darcs-patch
tests_-sort-default_extensions.dpatch ganesh, 2020-02-15.15:19:58 application/x-darcs-patch
unnamed ganesh, 2020-02-15.15:19:58 text/plain
unnamed ganesh, 2020-02-15.17:27:23 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg21819 (view) Author: ganesh Date: 2020-02-15.15:19:58 
some LANGUAGE cleanups for the test harness
5 patches for repository darcs-unstable@darcs.net:screened:

patch 747d75e19cc3652e62db5ef91b2c7b27f2759619
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 14:36:32 GMT 2020
  * tests: sort default-extensions

patch af16ca9f2636931774686e8f12d556c5048d234f
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 14:40:40 GMT 2020
  * tests: add DefaultSignatures to .cabal file

patch d69117711c7e7c89393176cfc224b9c71fcf743f
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 14:55:42 GMT 2020
  * tests: remove some redundant LANGUAGE pragmas

patch 2df3c52bfa260cc15c7a6a7eff245eb10938d611
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 14:56:35 GMT 2020
  * tests: list MultiParamTypeClasses in the cabal file
  
  It's very widely used in the tests and generally we wouldn't
  think twice about using it in test code/infrastructure.

patch 7a415dccdb33e436a098e86ec4101525d0518bf5
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 15:18:04 GMT 2020
  * tests: remove unnecessary UndecidableInstances
Attachments
msg21820 (view) Author: ganesh Date: 2020-02-15.17:27:23 
I screwed up a couple of things with these patches due
to relying on my IDE (which doesn't reload after cabal file
changes) and not checking after a conflict resolution.

Apologies if anyone pulled the broken repo state.

2 patches for repository darcs-unstable@darcs.net:screened:

patch 2fc94901ecea15189ddb1f0c41e26db51533580b
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 17:12:59 GMT 2020
  * tests: NoMonoLocalBinds needs to come last

patch b2d90359fa8a5abe3fb1d9aae89b7f067a22b1d7
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat Feb 15 16:56:49 GMT 2020
  * tests: correct mistake in MultiParamTypeClasses patch
  
  I accidentally removed UndecidableInstances when resolving a
  local conflict.
Attachments
msg21946 (view) Author: bfrk Date: 2020-02-28.09:52:31 
All fine (with the fixes).
History
Date User Action Args
2020-02-15 15:19:58ganeshcreate
2020-02-15 15:20:19ganeshsetstatus: needs-screening -> needs-review
2020-02-15 17:27:23ganeshsetfiles: + patch-preview.txt, tests_-nomonolocalbinds-needs-to-come-last.dpatch, unnamed
messages: + msg21820
2020-02-28 09:52:31bfrksetstatus: needs-review -> accepted-pending-tests
messages: + msg21946
2020-06-20 08:38:08bfrksetstatus: accepted-pending-tests -> accepted