darcs

Patch 2174 support Cabal 3.4 (and 9 more)

Title support Cabal 3.4 (and 9 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-05-16.13:55:19 by ganesh, last changed 2021-06-03.13:43:19 by bfrk.

Files
File name Status Uploaded Type Edit Remove
darcs_cabal_-add-_wno_star_is_type-for-ghc-__-9_0_1.dpatch bfrk, 2021-05-19.13:10:06 application/x-darcs-patch
patch-preview.txt ganesh, 2021-05-16.13:55:18 text/x-darcs-patch
patch-preview.txt bfrk, 2021-05-19.13:10:06 text/x-darcs-patch
support-cabal-3_4.dpatch ganesh, 2021-05-16.13:55:18 application/x-darcs-patch
unnamed ganesh, 2021-05-16.13:55:18 text/plain
unnamed bfrk, 2021-05-19.13:10:06 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22784 (view) Author: ganesh Date: 2021-05-16.13:55:18
A bunch of version bumps and minor associated
fixes - in part motivated by GHC 9 compatibility.

10 patches for repository darcs-unstable@darcs.net:screened:

patch 2a034bcc04dfedb001936517aef8271ae2afe2b4
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 18:50:40 BST 2021
  * support Cabal 3.4

patch f377828e60e4e7391762aa25c3beb721f19b3ac1
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:01:29 BST 2021
  * support base 4.15

patch b1e14218f8860db1e247a5a2afec9aa7754081c4
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:01:36 BST 2021
  * support memory 0.16

patch b622c399ae7f820cdf652cc5cd0541ccd86b7485
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:01:58 BST 2021
  * support cryptonite 0.28 and 0.29

patch cd595f20cb984464866d180dd3d6e5f0654427b6
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:02:27 BST 2021
  * support constraints 0.13

patch 3770823376826436ae674a25f93692d75cc451dc
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:02:36 BST 2021
  * support bytestring 0.11

patch 54db929f45bf18ebc4fa1688fa7bf2e28dba0698
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:02:44 BST 2021
  * support time 1.10 and 1.11

patch 755a19f55bfd03509891b9919e457b1bbb90dd97
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 19:04:41 BST 2021
  * support attoparsec 0.14

patch 56467dc09aae8aa023fd00f0a45d55dfa637aa1e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 21:06:05 BST 2021
  * support QuickCheck 2.14
  
  Need to make the Test.QuickCheck imports explicit in
  one place because chooseAny was added as a new export
  from Test.QuickCheck in 2.14, so the import from
  Test.QuickCheck.Gen becomes redundant and causes a
  warning.

patch 782084f58cd2ca97bb0be7e5d962fe5a0d364384
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sat May 15 21:37:52 BST 2021
  * tests: fix warning with GHC 9.0
Attachments
msg22785 (view) Author: bfrk Date: 2021-05-19.11:53:20
I tried building the head with

> cabal-3.4 update && cabal-3.4 build -w ghc-9.0.1

but it fails when compiling the dependencies:

Building library for regex-compat-tdfa-0.95.1.4..
[1 of 1] Compiling Text.Regex       ( Text/Regex.hs,
dist/build/Text/Regex.o, dist/build/Text/Regex.dyn_o )

Text/Regex.hs:142:22: error:
    Bang pattern in expression context: !0
    Did you mean to add a space after the '!'?
    |
142 |   let matches = map (!0) (matchAll delim strIn)
    |                      ^^
msg22786 (view) Author: ganesh Date: 2021-05-19.12:13:42
On 19/05/2021 12:53, Ben Franksen wrote:
> 
> Ben Franksen <ben.franksen@online.de> added the comment:
> 
> I tried building the head with
> 
>> cabal-3.4 update && cabal-3.4 build -w ghc-9.0.1
> 
> but it fails when compiling the dependencies:
> 
> Building library for regex-compat-tdfa-0.95.1.4..
> [1 of 1] Compiling Text.Regex       ( Text/Regex.hs,
> dist/build/Text/Regex.o, dist/build/Text/Regex.dyn_o )
> 
> Text/Regex.hs:142:22: error:
>     Bang pattern in expression context: !0
>     Did you mean to add a space after the '!'?
>     |
> 142 |   let matches = map (!0) (matchAll delim strIn)
>     |                      ^^

Yep - see https://hub.darcs.net/shelarcy/regex-compat-tdfa/issue/2

(I mentioned this in patch2172 but not here, sorry)

I've got a patch and also tried emailing the maintainer, no reply so
far. Next step after waiting a bit would be to ask the Hackage Trusteers
to do a non-maintainer upload or similar - or just inline the code
ourselves, it's only one file.
msg22787 (view) Author: bfrk Date: 2021-05-19.12:19:52
Ah, you already sent a fix for this issue
(https://hub.darcs.net/shelarcy/regex-compat-tdfa/issue/3).

BTW, I find it strange that we now get warnings from ghc because
something *will* be deprecated in the future. Should we add
-Wno-star-is-type to our ghc-options?
msg22788 (view) Author: bfrk Date: 2021-05-19.13:10:06
I like to build with -fwarn-as-error and this patch allows me to do that
with ghc-9.0.

1 patch for repository http://darcs.net/screened:

patch 6236d7861660b98e039ebb102b9afec611701388
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 19 15:31:44 CEST 2021
  * darcs.cabal: add -Wno-star-is-type for ghc >= 9.0.1
Attachments
msg22790 (view) Author: bfrk Date: 2021-05-19.13:15:05
(Perhaps i should not have sent my patch to this bundle.)

I was meaning to ask if you are okay with this before pushing to 
screened.
msg22792 (view) Author: ganesh Date: 2021-05-19.16:12:01
-Wno-star-is-type is fine with me for now, though I would rather "get with
the program" and update our code to use Type at some point. And no problem
with lumping it in this bundle.
msg22795 (view) Author: bfrk Date: 2021-05-20.08:38:13
Okay, I screened the patch. Agreed we should convert our code at some
point and then get rid of the extra option.
msg22831 (view) Author: bfrk Date: 2021-06-03.13:37:58
All fine, though

>   * tests: fix warning with GHC 9.0

feels a bit kludgy. Okay for now.

Reminds me of the preceding comment:

  -- TODO this check doesn't work at the moment - try to enable it and
see if it makes
  -- sense to keep or not.

I'd be interested: why does it not work? does it fail? can you give an
example?
msg22832 (view) Author: bfrk Date: 2021-06-03.13:43:19
Accepted, including my own follow-up patch.
History
Date User Action Args
2021-05-16 13:55:19ganeshcreate
2021-05-16 13:55:46ganeshsetstatus: needs-screening -> needs-review
2021-05-19 11:53:22bfrksetmessages: + msg22785
2021-05-19 12:13:43ganeshsetmessages: + msg22786
2021-05-19 12:19:52bfrksetmessages: + msg22787
2021-05-19 13:10:07bfrksetfiles: + patch-preview.txt, darcs_cabal_-add-_wno_star_is_type-for-ghc-__-9_0_1.dpatch, unnamed
messages: + msg22788
2021-05-19 13:15:05bfrksetmessages: + msg22790
2021-05-19 16:12:01ganeshsetmessages: + msg22792
2021-05-20 08:38:14bfrksetmessages: + msg22795
2021-06-03 13:37:59bfrksetmessages: + msg22831
2021-06-03 13:43:19bfrksetstatus: needs-review -> accepted
messages: + msg22832