Another small bunch of minor refactors, only loosely related.

5 patches for repository http://darcs.net/screened:

patch 74cd1deac7318b990d9c1fb2c19450b9603573e6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  2 22:35:52 CET 2021
  * rebase unsuspend: add more patch editing options
  
  These require no extra code, they are handled by updatePatchHeader.

patch 8e82b6cb0964ed7675ddc660a09dba6eff6ba649
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 18:17:00 CET 2021
  * add PatchHeaderConfig
  
  This groups everything we get from the command options into a record type to
  cut down on the number of parameters of updatePatchHeader. Also add the
  patchname option to rebase unsuspend and re-order the options so they are
  the same as for amend.

patch 5bb9b4e9ed9070c351013c5744f13f2f83c788dd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun  5 16:34:13 CEST 2021
  * remove duplicate definition of diffingOpts

patch 454fff356934d2ede4e40ee6bcf2ce44571f7b0d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun  5 16:36:53 CEST 2021
  * remove lookFor* functions from Darcs.UI.Flags
  
  Two of them are unused (outside of the defining module) and they all collide
  with the members of DiffOpts.

patch 38c9c4e5ce0d5dbf398a17d769e14fbbd643c7dc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jan 22 18:22:54 CET 2021
  * move command: readPlainTree -> readUnrecordedFiltered
  
  The difference is that readUnrecordedFiltered (with the given options) uses
  the index, if possible.

Attachments

• patch-preview.txt
• rebase-unsuspend_-add-more-patch-editing-options.dpatch
• unnamed

Sorry for another long gap in reviewing.

>    * rebase unsuspend: add more patch editing options

Fine.

>    * add PatchHeaderConfig

Nice cleanup.

>    * remove duplicate definition of diffingOpts

And again

>    * remove lookFor* functions from Darcs.UI.Flags

Fine.

>    * move command: readPlainTree -> readUnrecordedFiltered

Fine.