Patch 2243 fix: hard-linking between repo and cache should be ent...

Title fix: hard-linking between repo and cache should be ent...
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To

Created on 2022-06-02.11:24:16 by bfrk, last changed 2023-06-25.20:26:52 by bfrk.

File name Status Uploaded Type Edit Remove
cache_-explain-why-we-use-catchall-when-hard_linking-is-optional.dpatch bfrk, 2023-06-25.20:26:52 application/x-darcs-patch
fix_-hard_linking-between-repo-and-cache-should-be-entirely-optional.dpatch bfrk, 2022-06-02.11:24:10 application/x-darcs-patch
patch-preview.txt bfrk, 2022-06-02.11:24:10 text/x-darcs-patch
patch-preview.txt bfrk, 2023-06-25.20:26:52 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23003 (view) Author: bfrk Date: 2022-06-02.11:24:10
1 patch for repository http://darcs.net/screened:

patch a91e09b41fd2dddd651e768d8b40798f494f3f70
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 25 23:52:34 CEST 2022
  * fix: hard-linking between repo and cache should be entirely optional

  This fixes a bug introduced in

  patch 018c5978374ec2cb3ae4f918d733da948bda73da
  Author: Ben Franksen <ben.franksen@online.de>
  Date:   Mon Nov  9 15:47:50 CET 2020
    * improve cache utilization

  tryLinking catches only "does not exist" errors, so when hard-linking is
  optional, such as after we wrote the file to the repo, we should catch all
  exceptions. Note that tryLinking is *supposed* to throw exceptions, the
  logic in writeFileUsingCache depends on it.

  This came up in a situation where the repo and cache happened to be on
  different file systems, which caused most darcs commands to fail. I added a 
  line to tests/lib to run the tests in such a scenario, but it depends on a
  particular system setup and is therefore commented out.
msg23384 (view) Author: ganesh Date: 2023-06-24.15:38:14
OK (maybe worth a comment in the code?)
msg23427 (view) Author: bfrk Date: 2023-06-25.20:26:52
Good idea to add comments for these cases.

1 patch for repository http://darcs.net/screened:

patch 02a66b8b83916dbed69029a22292880285aa5f91
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jun 25 22:20:37 CEST 2023
  * cache: explain why we use catchall when hard-linking is optional
Date User Action Args
2022-06-02 11:24:16bfrkcreate
2022-06-02 20:57:01bfrksetstatus: needs-screening -> needs-review
2023-06-24 15:38:16ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23384
2023-06-24 16:16:21ganeshsetstatus: accepted-pending-tests -> accepted
2023-06-25 20:26:52bfrksetfiles: + patch-preview.txt, cache_-explain-why-we-use-catchall-when-hard_linking-is-optional.dpatch
messages: + msg23427