Some tests-related patches. 

There's also test failing-issue1325_pending_minimisation that's not failing
anymore on my laptop, but I couldn't find when it stopped failing: test
--linear runs for hours without failing, test --bisect fails to build almost
every try, so it's practically useless (most of the times, it fails because
cannot access a repo in Ben's github: I think at the time he was maintaining a
fork of a dependency). Anyway, as I could not find when it started succeeding,
I've left the test as failing.

5 patches for repository http://darcs.net/screened:

patch 729de162d61fd589546483be9feb861e928e6cf5
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Dec 19 11:54:35 CET 2022
  * t/network/ssh.sh: don't require the default user shell
  to be POSIX/bourne-compatible

patch 1f45fd54419405c7d4bc4fd68906b309e0db7294
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Dec 19 12:25:46 CET 2022
  * tests: the canonical path for env is /usr/bin/env

patch dbf0924ca055a8431805af77ba154ed9df2ccf87
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Dec 19 12:26:41 CET 2022
  * tests: support systems where bash is not installed in /bin (e.g.: BSDs)

patch c3ec33d3104c3e2ebf915dde0801a95cc8e8e24e
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Dec 19 12:33:58 CET 2022
  * ./t/network/sshlib: allow running the ssh tests
  when CanonicalizeHostname is set in user's ssh configuration

patch 395b1ee13bfe1136dcb0e5962a2da51b2b3d3bbf
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Mon Dec 19 21:39:56 CET 2022
  * t/network/httplib: allow running the http tests as unprivileged user
  when lighttpd is installed in (/usr)/sbin

Attachments

• patch-preview.txt
• t_network_ssh_sh_-don_t-require-the-default-user-shell.dpatch

These all look reasonable. A lot of network tests are skipped by default 
so I can't check if they all still work perfectly in the existing 
scenarios but I shall assume they do until proven otherwise :-)

FWIW, the only network tests that are skipped on my machine are

* network/clone-http-packed-detect and network/clone-http-packed for 
darcs-1 and darcs-3 (because we test with a zipped repo that happens 
to be in darcs-2 format)

* network/issue1503_prefer_local_caches_to_remote_one for all 3 
formats because the remote repo http://darcs.net/testing/repo1 no 
longer exists

Regarding the second point, I could not find any directory named 
"testing" nor "repo1" under /opt/archive/vm1. So it appears this 
test repo is lost. I am not sure why the test required a special 
repo on darcs.net. In any case it is currently defunct, so I 
wouldn't mind deleting it.

* [Sun, Jan 01, 2023 at 03:36:59PM +0000] Ganesh Sittampalam:
>These all look reasonable. A lot of network tests are skipped by 
>default so I can't check if they all still work perfectly in the 
>existing scenarios but I shall assume they do until proven otherwise 
>:-)

Please double check that in your case none of the network tests are 
skipped *because* of these patches (with the obvious culprit being 
c3ec33d3104c3e2ebf915dde0801a95cc8e8e24e). That change should be safe, 
but just in case...

You also mentioned failing-issue1325_pending_minimisation which no 
longer fails. Thanks for the hint, I will send a patch that renames 
the test to re-enable it and will close the issue, unless you want to 
/ have already done it.

(Finding out exactly when and how something was fixed is "nice to 
have".)