Patch 2282 improve progress reporting

Title improve progress reporting
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To bfrk

Created on 2023-02-22.22:15:45 by bfrk, last changed 2023-06-06.08:49:36 by bfrk.

File name Status Uploaded Type Edit Remove
add-withprogress-and-withsizedprogress-to-darcs_util_progress.dpatch bfrk, 2023-02-22.22:15:43 application/x-darcs-patch
patch-preview.txt bfrk, 2023-02-22.22:15:43 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23122 (view) Author: bfrk Date: 2023-02-22.22:15:43
Will self-accept this one.

4 patches for repository http://darcs.net/screened:

patch 1537cece47a55f484d149e5191a5bf282dee2fa6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec 12 19:54:06 CET 2022
  * add withProgress and withSizedProgress to Darcs.Util.Progress

patch a7eda1d88aec7ae7b7db0764f7388159f8ad494e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Dec  8 14:22:30 CET 2022
  * add progress reporting to writeDarcsHashed

patch 65932f3609f81140bb78a177452f7fa8e09d91df
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec 12 18:50:51 CET 2022
  * improve and simplify progress reporting

  It would previously drop whole items from the output line if it gets too
  long (>80 chars). This is bad because it often means you don't see any
  "progress" at all, just the key phrase (possibly for a long time, suggesting
  darcs is stuck when it is not). We now always print the long version and cut
  off chars exceeding the actual terminal width. To determine that we now
  depend on the terminal-size package.

patch b92b774c0f336e28734ca4fa11b682b7757bb58c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Aug 18 13:30:26 CEST 2022
  * improve progress reporting when merging patches

  All parts of merging that are potentially slow are now covered and can be
  clearly recognized.
msg23137 (view) Author: bfrk Date: 2023-03-08.20:33:10
This change breaks the build on Windows because terminal-size does not 
export hSize on Windows. I am trying to find a solution.
msg23138 (view) Author: bfrk Date: 2023-03-12.06:42:24
A pull request for terminal-size that adds support for hSize on 
Windows is now pending review.
msg23197 (view) Author: bfrk Date: 2023-03-27.13:01:29
The (self-)requested patch was

patch 2a6743d1bb467a4843b5d05f9e1d50cd7fc05bfe
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar 14 08:59:08 CET 2023
  * require terminal-size >= 0.3.4 which has hSize on Windows, too

which is in patch2287 (I failed to attach the bundle to this ticket, 
Date User Action Args
2023-02-22 22:15:45bfrkcreate
2023-02-22 22:16:13bfrksetstatus: needs-screening -> accepted-pending-tests
2023-03-08 20:33:13bfrksetstatus: accepted-pending-tests -> followup-requested
assignedto: bfrk
messages: + msg23137
2023-03-12 06:42:26bfrksetmessages: + msg23138
2023-03-27 13:01:29bfrksetstatus: followup-requested -> accepted-pending-tests
messages: + msg23197
2023-06-06 08:49:36bfrksetstatus: accepted-pending-tests -> accepted