2 patches for repository http://darcs.net/screened:

patch 0893e647430e5d49c5a5d1acef9ae85058e9984a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 20 14:58:44 CEST 2023
  * add --reorder-patches option to push

  It was already supported for apply, so all we need to do is pass it through
  to the remote apply command.

patch 5a6a9fbfbe6c62bd4671099ed105a30066c63995
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug 20 17:29:28 CEST 2023
  * push: pass through options to apply in all cases

  We previously did not pass --debug and --reorder-patches when we had
  --apply-as in effect. This patch includes a bit of refactoring to unify the
  4 different ways we execute the "remote" darcs apply, depending on whether
  the remote repo is a ssh URL and whether we apply via sudo for --apply-as.

Attachments

• add-__reorder_patches-option-to-push.dpatch
• patch-preview.txt

> hunk ./src/Darcs/UI/Options/All.hs 1027
> +-- | push; same as 'reorder' but with help descriptions swapped
> +reorderPush :: PrimDarcsOption Reorder
> +reorderPush = withDefault NoReorder
> +  [ RawNoArg [] ["reorder-patches"] F.Reorder Reorder
> +    "put remote-only patches on top of local ones"
> +  , RawNoArg [] ["no-reorder-patches"] F.NoReorder NoReorder
> +    "put local-only patches on top of remote ones" ]

Local and remote are a bit confusing to me here given we're talking
about the other repo. Maybe we should be more explicit by saying
things like "put patches that are only in the other repository on top
of the ones that are present in this repository"? It's a bit verbose though.

Rest of the code looks fine.

I agree that the wording of the short help text for the option is not
perfect in this case, but given that we have to find a compromise between
precision and verbosity I think it's okay as is. Instead, here is an
addition to the help text for the push command that is more explicit and
also mentions a possible use case. (In fact, this is what prompted me to
implement this.)

Not yet screened, just in case.

1 patch for repository http://darcs.net/screened:

patch 2ef13f84f9123603abee9607c18204ef777f3ba3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 29 10:58:51 CEST 2023
  * extend help for push with explanation of --reorder-patches

Attachments

• extend-help-for-push-with-explanation-of-__reorder_patches.dpatch
• patch-preview.txt

That message looks reasonable. Do we already talk about "clean tags"
in our docs? I didn't spot any cases from a quick grep.

Following up on your latest observation. Fits nicely in, since we already
talked about the concept without giving it a name.

1 patch for repository https://darcs.net/screened:

patch 11e4fd3514446ec8509f2043713c8018fa91bcd6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 29 15:49:19 CEST 2023
  * define "clean tag" in help for tag command

Attachments

• define-_clean-tag_-in-help-for-tag-command.dpatch

Both follow-ups are screened now.

All looks good