darcs

Patch 2375 Darcs.Patch.Annotate: fix warning about ... (and 11 more)

Title Darcs.Patch.Annotate: fix warning about ... (and 11 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2024-02-25.21:55:36 by ganesh, last changed 2024-06-02.12:56:04 by ganesh.

Files
File name Status Uploaded Type Edit Remove
darcs_patch_annotate_-fix-warning-about-head.dpatch ganesh, 2024-02-25.21:55:35 application/x-darcs-patch
patch-preview.txt ganesh, 2024-02-25.21:55:35 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg23775 (view) Author: ganesh Date: 2024-02-25.21:55:35
12 patches for repository darcs-unstable@darcs.net:/opt/darcs/screened:

patch 025abbe56e96042310ccd8c14ea7a465558005cb
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 18:25:03 GMT 2024
  * Darcs.Patch.Annotate: fix warning about head

patch b23d269af0575f09e7c9b2e8a680d01c71a2b3ef
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 19:40:09 GMT 2024
  * Darcs.Util.Diff.Patience: fix warning about head

patch 0c58f8ccc763d086f49fbd1b6b9075a91406b31e
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 19:51:47 GMT 2024
  * Darcs.Patch.Info: fix warning about head

patch 87ceafce4cb72c9604821d84a636a98e0a2a8251
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 20:15:16 GMT 2024
  * darcs.hs: fix warnings about head/tail

patch e20f80de6abd831de59b5d7e851c108633ea62a1
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 20:41:19 GMT 2024
  * add some tests for Darcs.UI.Commands.Convert.Export.patchAuthor

patch 0cd3942f6cedbc52b10acd661e0322c3592c520c
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 20:42:14 GMT 2024
  * Darcs.UI.Commands.Convert.Export: fix warnings about tail

patch 3b37e556d4645bb6eaa904b47c112c6089580aed
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 20:55:24 GMT 2024
  * Darcs.UI.Commands.Convert.Import: fix warning about head

patch 97ab9dd3c4add8d4252c0470e2581052a6a17df4
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 20:55:52 GMT 2024
  * Darcs.UI.Commands.Record: fix warning about head

patch bcc5115d171dfedd158f989a50f768626ce739f3
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 21:51:35 GMT 2024
  * Darcs.Test.Patch.FileUUIDModel: fix warning about head/tail

patch b22c5b5e2ea2489c2a9947f02bc80be16ac45abb
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 21:52:04 GMT 2024
  * use headErr/tailErr from safe for several head/tails

  They aren't trivial to fix in a concise way, and safe
  is generally a useful package to have around anyway.

patch e3a0f924e3b24c4c4207f43bde7d0d98729433de
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 21:52:14 GMT 2024
  * Darcs.UI.Commands.ShowAuthors: fix warnings about head

patch ce3f6ee456ec5b94a28e3e08166c3b9462bf105d
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 21:52:57 GMT 2024
  * Darcs.UI.External: fix warnings about head
Attachments
msg23780 (view) Author: ganesh Date: 2024-03-09.15:12:56
self-accepting
msg23930 (view) Author: bfrk Date: 2024-06-02.12:28:05
As a reminder for the future: changes such as 

patch b22c5b5e2ea2489c2a9947f02bc80be16ac45abb
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Feb 25 21:52:04 GMT 2024
  * use headErr/tailErr from safe for several head/tails

  They aren't trivial to fix in a concise way, and safe
  is generally a useful package to have around anyway.

could be done easier and with less churn by replacing Darcs.Prelude.tail  
with the version from Safe module. Changes like this one are why we have 
Darcs.Prelude in the first place.
msg23931 (view) Author: ganesh Date: 2024-06-02.12:56:04
Most of the other changes were to actually rewrite code to not use
head/tail though - I wouldn't have wanted to do a blanket suppression
of the warning by changing all of them via Darcs.Prelude.
History
Date User Action Args
2024-02-25 21:55:36ganeshcreate
2024-03-09 15:12:57ganeshsetstatus: needs-screening -> accepted-pending-tests
messages: + msg23780
2024-03-24 09:47:52ganeshsetstatus: accepted-pending-tests -> accepted
2024-06-02 12:28:05bfrksetmessages: + msg23930
2024-06-02 12:56:04ganeshsetmessages: + msg23931