darcs

Patch 2418 resolve issue2288: add --covering PATTERN option to sh...

Title resolve issue2288: add --covering PATTERN option to sh...
Superseder Nosy List bfrk
Related Issues
Status needs-review Assigned To
Milestone

Created on 2024-06-22.19:47:06 by bfrk, last changed 2024-12-04.09:55:56 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2024-06-22.19:47:04 text/x-darcs-patch
patch-preview.txt bfrk, 2024-12-04.09:52:59 text/x-darcs-patch
resolve-issue2288_-add-__covering-pattern-option-to-show-tags-command.dpatch bfrk, 2024-06-22.19:47:04 application/x-darcs-patch
resolve-issue2288_-add-__covering-pattern-option-to-show-tags-command_0.dpatch bfrk, 2024-12-04.09:53:00 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg24042 (view) Author: bfrk Date: 2024-06-22.19:47:04
I was bored, so looked at old tickets and found this. Not sure if it's worth
the code, but someone once asked for it and it was simple enough to do.

The core functionality is in Darcs.Patch.Set.tagsCovering. Is this the right
place for it? I put it there because patchSetTags (the function used when we
have no --covering option) is also in that module.

1 patch for repository https://darcs.net/screened:

patch 3e3d4a4c81e2a9ce99766cfc766509e3ef9aa1b9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun 22 09:37:33 CEST 2024
  * resolve issue2288: add --covering PATTERN option to show tags command
Attachments
msg24062 (view) Author: ganesh Date: 2024-07-20.17:23:38
It does seem a bit obscure from the description, but the motivation
in issue2288 makes sense to me.

Perhaps the help string could avoid the word "covering" and instead
say "containing"? I think the "(only)" is redundant too, if we are being
that precise we should use it almost everywhere.
msg24118 (view) Author: bfrk Date: 2024-11-30.13:11:34
Agreed regarding the "(only)".

I doubt that "containing" is any better than "covering". Neither term is 
defined in the docs (I checked), so we rely on an intuitive understanding 
anyway.

What about

    "show tags that depend on the latest patch that matches PATTERN"

?
msg24119 (view) Author: bfrk Date: 2024-12-04.09:53:00
Following up on your comment.

2 patches for repository https://darcs.net/screened:

patch 3e3d4a4c81e2a9ce99766cfc766509e3ef9aa1b9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jun 22 09:37:33 CEST 2024
  * resolve issue2288: add --covering PATTERN option to show tags command

patch 2a38a9de33638564b821d95a69acfcfbc3837149
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Nov 30 14:11:59 CET 2024
  * improve help text for --covering option
Attachments
msg24120 (view) Author: bfrk Date: 2024-12-04.09:55:52
I am screening since you seem to be in favour in principle.
History
Date User Action Args
2024-06-22 19:47:06bfrkcreate
2024-07-20 17:23:39ganeshsetmessages: + msg24062
2024-11-30 13:11:35bfrksetmessages: + msg24118
2024-12-04 09:53:04bfrksetfiles: + patch-preview.txt, resolve-issue2288_-add-__covering-pattern-option-to-show-tags-command_0.dpatch
messages: + msg24119
2024-12-04 09:55:56bfrksetstatus: needs-screening -> needs-review
messages: + msg24120