Patch 274: Add test for issue1210: global cache gets recorded - Darcs bug tracker

Title	Add test for issue1210: global cache gets recorded
Superseder		Nosy List	abuiles, kowey
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-06-08.01:23:32 by abuiles, last changed 2011-05-10.20:06:37 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
add-test-for-issue1210_-global-cache-gets-recorded-in-_darcs_prefs_sources.dpatch		abuiles, 2010-06-08.01:23:32	text/x-darcs-patch
amend-patch274-skip-test-in-windows.dpatch		abuiles, 2010-06-08.19:26:03	text/x-darcs-patch
unnamed		abuiles, 2010-06-08.01:23:32
unnamed		abuiles, 2010-06-08.19:26:03

See mailing list archives for discussion on individual patches.

Messages
msg11318 (view)	Author: abuiles	Date: 2010-06-08.01:23:32
1 patch for repository http://darcs.net: Mon Jun 7 20:09:02 COT 2010 builes.adolfo@googlemail.com * Add test for issue1210: global cache gets recorded in _darcs/prefs/sources Attachments add-test-for-issue1210_-global-cache-gets-recorded-in-_darcs_prefs_sources.dpatch unnamed
msg11323 (view)	Author: kowey	Date: 2010-06-08.09:04:06
Add test for issue1210: global cache gets recorded in _darcs/prefs/sources -------------------------------------------------------------------------- > hunk ./tests/issue1210_global_cache_gets_recorded_in_darcs_prefs_sources.sh 26 > +set -ev > + > +. lib > + > +cacheDir=$HOME/.darcs/cache > + > +rm -rf R S > +darcs init --repo R > +darcs get R S > +not grep "$cacheDir" S/_darcs/prefs/sources Seems fairly straightforward. Applied, thanks! By the way, that's an awfully long test name. I've taken the liberty of renaming that to issue1210-no-global-cache-in-sources.sh -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
msg11331 (view)	Author: darcswatch	Date: 2010-06-08.10:23:01
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f699ff3a507340a892724e707836fec98bd6fb50
msg11335 (view)	Author: abuiles	Date: 2010-06-08.19:26:03
1 patch for repository http://darcs.net: Tue Jun 8 13:59:48 COT 2010 builes.adolfo@googlemail.com * Amend patch274 skip test in windows Attachments amend-patch274-skip-test-in-windows.dpatch unnamed
msg11336 (view)	Author: kowey	Date: 2010-06-09.09:34:15
On Tue, Jun 08, 2010 at 19:26:03 +0000, Adolfo Builes wrote: > Tue Jun 8 13:59:48 COT 2010 builes.adolfo@googlemail.com > * Amend patch274 skip test in windows As discussed on IRC, it looks like the test actually caught a potential bug which we need to work out. Good work! (Tests catching bugs is happy time) -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
msg11337 (view)	Author: kowey	Date: 2010-06-09.09:39:54
Oh! I see what happened. Adolfo, when a patch has been accepted already, it's easier for tracking purposes if you just submit a new patch rather than trying to add to the ticket. Basically, once a ticket is closed it should generally stay that way :-)
msg14253 (view)	Author: darcswatch	Date: 2011-05-10.20:06:37
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-f699ff3a507340a892724e707836fec98bd6fb50

History
Date	User	Action	Args
2010-06-08 01:23:32	abuiles	create
2010-06-08 01:24:55	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f699ff3a507340a892724e707836fec98bd6fb50
2010-06-08 09:04:06	kowey	set	nosy: + kowey messages: + msg11323
2010-06-08 10:23:01	darcswatch	set	status: needs-review -> accepted messages: + msg11331
2010-06-08 19:26:03	abuiles	set	files: + amend-patch274-skip-test-in-windows.dpatch, unnamed messages: + msg11335
2010-06-08 19:26:44	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f699ff3a507340a892724e707836fec98bd6fb50 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0ff5b93f28f0f17619537d7d14fcfda168d50964
2010-06-09 09:34:16	kowey	set	status: accepted -> rejected messages: + msg11336 title: Add test for issue1210: global cache gets recorded in ... -> Add test for issue1210: global cache gets recorded
2010-06-09 09:39:54	kowey	set	messages: + msg11337
2011-05-10 17:35:56	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0ff5b93f28f0f17619537d7d14fcfda168d50964 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0ff5b93f28f0f17619537d7d14fcfda168d50964
2011-05-10 20:06:37	darcswatch	set	status: rejected -> accepted messages: + msg14253