1 patch for repository http://darcs.net:

Note: not screened because I'm not even sure this is a sensible thing to want
(see issue2100; go ahead and screen if I'm just being silly)

Wed Sep  7 17:59:15 BST 2011  Eric Kow <kowey@darcs.net>
  * Accept issue2100: darcs add should move on from first failure.

Attachments

• accept-issue2100_-darcs-add-should-move-on-from-first-failure_.dpatch
• unnamed
• unnamed

Changing the (failing test) so that it verifies that exit code
be non-zero as soon as one add fails.
(see http://bugs.darcs.net/issue2100)

1 patch for repository http://darcs.net:

Thu Mar 22 14:52:38 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * make exit code of darcs add non-zero if any adds fail

Attachments

• make-exit-code-of-darcs-add-non_zero-if-any-adds-fail.dpatch
• patch-preview.txt
• unnamed

gh's exit code patch looks good.

> hunk ./tests/failing-issue2100-add-failures.sh
> +not darcs add d/non-existent d/f
> +darcs whatsnew > log2 2>&1
> +grep "./d/non-existent does not exist" log2

This tests for whatsnew giving an error after a failed add.  As I 
understand issue2100, we want add to give the error.  Eric, did you mean 
to capture and grep "darcs add" output?

mndrix's comment is correct.

I've just self-accepeted a followup patch that fixes the test script
accordingly:

 hunk ./tests/failing-issue2100-add-failures.sh 34
-not darcs add d/non-existent d/f
+not darcs add d/non-existent d/f  > log1 2>&1
hunk ./tests/failing-issue2100-add-failures.sh 36
-grep "./d/non-existent does not exist" log2
+grep "./d/non-existent does not exist" log1

Accepting all of this. (Patches for test scripts can be self-accepted
according to http://wiki.darcs.net/Development/PatchReview, for those
who wonder.)