|
Created on 2009-02-04.09:18:41 by mornfall, last changed 2011-04-01.14:46:30 by noreply.
msg7271 (view) |
Author: mornfall |
Date: 2009-02-04.09:18:38 |
|
Hi,
this is the promised runtime check for sendmail and diff.
Yours,
Petr.
PS: I have checked that these work. This mail is from darcs send with the
patch applied.
PPS: The check is done a little too late, *after* patch selection. This should
be remedied somehow, ie. don't let people select patches if we know we won't be
able to send them. But that's for separate patch. CC-ing bugs@darcs.net.
Tue Feb 3 16:56:56 CET 2009 Petr Rockai <me@mornfall.net>
* Cabal: Do not make absence of a diff tool fatal.
Wed Feb 4 10:13:20 CET 2009 Petr Rockai <me@mornfall.net>
* Look for diff & sendmail at runtime, not compile time.
Attachments
|
msg7650 (view) |
Author: kowey |
Date: 2009-04-09.16:02:54 |
|
I'm just highlighting the relevant part of Petr's message in case anybody is
confused: "The check is done a little too late, *after* patch selection. Don't
let people select patches if we know we won't be able to send them."
So it seems like the logic should be: "am I sending over the network? (as
opposed to just to a file)" and if so, "can I do it?" and if not "sorry! you
don't have a working sendmail instance on your machine"
|
msg13339 (view) |
Author: kerneis |
Date: 2010-12-15.15:14:53 |
|
Resolved in patch505.
|
msg13857 (view) |
Author: noreply |
Date: 2011-04-01.14:46:29 |
|
The following patch sent by Gabriel Kerneis <kerneis@pps.jussieu.fr> updated issue issue1344 with
status=resolved;resolvedin=2.8.0 HEAD
* resolve issue1344: abort early if can't send
Ignore-this: 42f5d52f6e1ef0001a6f458b252e4ee4
|
|
Date |
User |
Action |
Args |
2009-02-04 09:18:41 | mornfall | create | |
2009-03-28 03:12:26 | twb | set | nosy:
darcs-users, kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall title: darcs patch: Cabal: Do not make absence of a diff too... (and 1 more) -> darcs send: abort early if can't send. |
2009-03-31 19:55:09 | tux_rocker | set | priority: bug nosy:
darcs-users, kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall |
2009-04-09 16:03:00 | kowey | set | topic:
+ UI nosy:
- darcs-users status: unread -> unknown messages:
+ msg7650 |
2009-08-16 22:40:23 | kowey | set | status: unknown -> needs-implementation nosy:
kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall |
2009-08-25 17:40:29 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:25:00 | admin | set | nosy:
kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, mornfall |
2010-03-25 11:45:51 | kowey | set | topic:
+ ProbablyEasy nosy:
+ jaredj |
2010-12-09 01:33:41 | kerneis | set | assignedto: kerneis nosy:
+ kerneis |
2010-12-15 15:14:54 | kerneis | set | status: needs-implementation -> has-patch messages:
+ msg13339 |
2011-04-01 14:46:30 | noreply | set | status: has-patch -> resolved messages:
+ msg13857 resolvedin: 2.8.0 |
|