darcs

Issue 337 say when patches are automatically pre-selected due to dependencies

Title say when patches are automatically pre-selected due to dependencies
Priority feature Status needs-implementation
Milestone Resolved in
Superseder Nosy List ashmoran, bucket, cmm, dmitry.kurochkin, galbolle, kowey, markstos, thorkilnaur, tim, tommy
Assigned To
Topics Matchers, UI

Created on 2006-11-08.21:07:17 by kowey, last changed 2010-08-10.17:34:32 by ashmoran.

Messages
msg1190 (view) Author: kowey Date: 2006-11-08.21:07:15
Darcs really ought to know the difference between a patch that has been
explicitly requested, and one that it has selected because of a depedency. 
Doing so would allow us to tell the user (for example) that we are pushing a
patch because we depend on it, even though it wasn't selected with --match.

See issue333
msg8681 (view) Author: kowey Date: 2009-09-04.09:45:34
This is actually a pretty important thing to work on.  It may require an
overhaul of the SelectChanges code

See also
--------
- issue125: I'm resurrecting this because I realise now that it's not *quite*
the same thing as issue125.
- issue762: filed by Tim Chevalier has a rather nice explanation of what we want
(see msg4035)
- issue1123: is vaguely related
- http://wiki.darcs.net/PatchSelectionMechanism
msg12085 (view) Author: kowey Date: 2010-08-10.16:40:04
We've recently had a discussion on darcs-users, and a concrete user 
interface has surfaced:

http://lists.osuosl.org/pipermail/darcs-users/2010-August/024817.html

Before
------
 $ darcs rollback -p Hardlink
  Mon Aug  2 04:54:45 BST 2010  Alexey Levan <exlevan at gmail.com>
    * Minimize the number of packed inventories
  Shall I rollback this patch? (1/3)  [ynW...], or ? for more options: y
  Mon Aug  2 03:49:14 BST 2010  Alexey Levan <exlevan at gmail.com>
    * Use cache while getting a packed repository
  Shall I rollback this patch? (2/3)  [ynW...], or ? for more options: y
  Sun Aug  1 06:03:49 BST 2010  Alexey Levan <exlevan at gmail.com>
    * Hardlink files while getting a packed repository
  Shall I rollback this patch? (3/3)  [ynW...], or ? for more options: 

After
-----
  $ darcs rollback -p Hardlink
  Sun Aug  1 06:03:49 BST 2010  Alexey Levan <exlevan@gmail.com>
    * Hardlink files while getting a packed repository

  There are 2 patches that depend on this patch. Hit 'i' to see them.
  Shall I rollback this patch? (3/3) [ynW...], or ? for more options: y
  OK, will also roll back its 2 dependants

There are a couple of details to sort out, such as how you count the 
dependencies (given that a patch may depend on more than one matching 
patch) and how this interacts with patch navigation.  But I suspect 
whoever implements this will only really make progress by trying and 
seeing.
msg12087 (view) Author: markstos Date: 2010-08-10.17:00:17
> After
> -----
>   $ darcs rollback -p Hardlink
>   Sun Aug  1 06:03:49 BST 2010  Alexey Levan <exlevan@gmail.com>
>     * Hardlink files while getting a packed repository
> 
>   There are 2 patches that depend on this patch. Hit 'i' to see them.
>   Shall I rollback this patch? (3/3) [ynW...], or ? for more options: y
>   OK, will also roll back its 2 dependants
> 
> There are a couple of details to sort out, such as how you count the 
> dependencies (given that a patch may depend on more than one matching 
> patch) and how this interacts with patch navigation.  But I suspect 
> whoever implements this will only really make progress by trying and 
> seeing.

I like this new direction-- thanks for the team for working on it. My
suggested refinement: Might the prompt also notify you that
dependencies must also be rolled back?

Perhaps this:

 There are 2 patches that depend on this patch and will also be rolled
 back if this patch is selected. Hit 'i' to see them.
 Shall I rollback this patch? (3/3) [ynW...], or ? for more options: y
 OK, will also roll back its 2 dependants

OTOH, the original proposed prompt was shorter, and perhaps it's a
detail you expect people to learn as they use the software a little bit,
and then don't need the more verbose prompt anymore.

    Mark
msg12090 (view) Author: ashmoran Date: 2010-08-10.17:34:31
On 10 Aug 2010, at 18:00, Mark Stosberg wrote:

> OTOH, the original proposed prompt was shorter, and perhaps it's a
> detail you expect people to learn as they use the software a little bit,
> and then don't need the more verbose prompt anymore.

I'm all for interfaces that make it obvious to beginners what features are available (or easy to find out what they are), without drowning experienced users in noise.

-- 
http://www.patchspace.co.uk/
http://www.linkedin.com/in/ashleymoran
History
Date User Action Args
2006-11-08 21:07:17koweycreate
2007-08-08 08:00:03koweysetstatus: unread -> duplicate
nosy: + beschmi
superseder: + tell users when we skip patches in interactive mode
2009-08-06 17:40:10adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy, cmm, bucket
2009-08-06 20:37:14adminsetnosy: - beschmi
2009-08-10 21:58:28adminsetnosy: + cmm, bucket, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:53:44adminsetnosy: + darcs-devel, - simon
2009-08-27 13:51:13adminsetnosy: tommy, kowey, darcs-devel, cmm, bucket, thorkilnaur, dmitry.kurochkin
2009-09-04 09:40:05koweylinkissue762 superseder
2009-09-04 09:45:39koweysetstatus: duplicate -> needs-implementation
topic: + UI, Matchers
title: distinguish between explicitly requested patches and dependencies -> say when patches are automatically pre-selected due to dependencies
nosy: + markstos, tim
messages: + msg8681
priority: wishlist -> feature
superseder: - tell users when we skip patches in interactive mode
2010-08-10 16:40:05koweysetnosy: + galbolle, ashmoran, - darcs-devel
messages: + msg12085
2010-08-10 17:00:17markstossetmessages: + msg12087
2010-08-10 17:34:32ashmoransetmessages: + msg12090