darcs

Issue 358 setting defaultrepo to '.' leads to crash on pull

Title setting defaultrepo to '.' leads to crash on pull
Priority bug Status resolved
Milestone Resolved in
Superseder pull "." => Not a repository
View: 427
Nosy List bfr, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy
Assigned To kowey
Topics

Created on 2006-11-27.12:10:30 by benjamin.franksen, last changed 2009-10-23.23:46:08 by admin.

Messages
msg1274 (view) Author: bfr Date: 2006-11-27.12:10:29
I tried to set defaultrepo to '.' as a workaround for issue 357. This 
got me:

aragon: .../esd/base-3-13 > echo '.' > _darcs/prefs/defaultrepo
aragon: .../esd/base-3-13 > darcs pull 

Fail: bug in darcs!
Empty filename in is_relative
Please report this to bugs@darcs.net,
If possible include the output of 'darcs --exact-version'.
aragon: .../esd/base-3-13 > darcs --exact-version
darcs compiled on Nov 20 2006, at 14:47:31
# configured Fri Jun 16 14:55:21 EDT 2006
./configure --no-create --no-recursion

Context:

[TAG 1.0.8
Tommy Pettersson <ptp@lysator.liu.se>**20060616160213] 

Ben
msg1299 (view) Author: droundy Date: 2006-11-29.16:33:08
On Mon, Nov 27, 2006 at 12:10:30PM +0000, benjamin.franksen wrote:
> I tried to set defaultrepo to '.' as a workaround for issue 357. This 
> got me:
> 
> aragon: .../esd/base-3-13 > echo '.' > _darcs/prefs/defaultrepo
> aragon: .../esd/base-3-13 > darcs pull 
> 
> Fail: bug in darcs!
> Empty filename in is_relative
> Please report this to bugs@darcs.net,
> If possible include the output of 'darcs --exact-version'.

This is a bug, in that darcs should fail with a nicer error message.  But
putting "." in the defaultrepo itself I'd call a user mistake.  Why is it
that you feel a need to work around issue 357?
-- 
David Roundy
Department of Physics
Oregon State University
msg1301 (view) Author: bfr Date: 2006-11-29.19:57:04
On Wednesday 29 November 2006 17:33, David Roundy wrote:
> David Roundy <droundy@darcs.net> added the comment:
>
> On Mon, Nov 27, 2006 at 12:10:30PM +0000, benjamin.franksen wrote:
> > I tried to set defaultrepo to '.' as a workaround for issue 357.
> > This got me:
> >
> > aragon: .../esd/base-3-13 > echo '.' > _darcs/prefs/defaultrepo
> > aragon: .../esd/base-3-13 > darcs pull
> >
> > Fail: bug in darcs!
> > Empty filename in is_relative
> > Please report this to bugs@darcs.net,
> > If possible include the output of 'darcs --exact-version'.
>
> This is a bug, in that darcs should fail with a nicer error message. 
> But putting "." in the defaultrepo itself I'd call a user mistake. 

Of course, it doesn't make sense. As I said, I was just playing around, 
trying to find some work-around for issue 357. I probably wouldn't have 
reported this had darcs not explicitly begged me to do so ;-)

> Why is it that you feel a need to work around issue 357?

I felt that having a defaultrepo doesn't make sense for a primary repo, 
and wanted to avoid possibe confusion for less experienced users. It's 
far from a necessity to have that feature, it would just be nice.

Cheers
Ben
msg2242 (view) Author: kowey Date: 2007-11-04.22:57:34
Resolved in unstable with

Sun Aug 19 22:16:19 CEST 2007  Eric Kow <eric.kow@gmail.com>
  * [issue354, issue358] Handle corner cases pulling from self.
History
Date User Action Args
2006-11-27 12:10:30benjamin.franksencreate
2006-11-29 16:33:14droundysetstatus: unread -> unknown
nosy: droundy, tommy, kowey, benjamin.franksen
messages: + msg1299
2006-11-29 19:57:12benjamin.franksensetnosy: droundy, tommy, kowey, benjamin.franksen
messages: + msg1301
2006-12-05 21:55:04droundysetnosy: droundy, tommy, kowey, benjamin.franksen
2007-07-21 09:06:40koweysetnosy: + beschmi
superseder: + pull "." => Not a repository
2007-11-04 22:57:34koweysetstatus: unknown -> resolved-in-unstable
messages: + msg2242
2007-11-17 11:10:35koweysetstatus: resolved-in-unstable -> resolved-in-stable
2008-09-16 21:30:38adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:35:32adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, benjamin.franksen
2009-08-06 20:32:41adminsetnosy: - beschmi
2009-08-10 21:59:18adminsetnosy: + benjamin.franksen, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:58:22adminsetnosy: - dagit
2009-08-25 17:49:46adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:20adminsetnosy: tommy, kowey, darcs-devel, benjamin.franksen, thorkilnaur, dmitry.kurochkin
2009-10-23 23:46:08adminsetnosy: + bfr, - benjamin.franksen