darcs

Issue 427 pull "." => Not a repository

Title pull "." => Not a repository
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List chris.dawson, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy
Assigned To kowey
Topics

Created on 2007-04-03.14:45:54 by chris.dawson, last changed 2009-08-27.14:11:41 by admin.

Messages
msg1561 (view) Author: chris.dawson Date: 2007-04-03.14:45:45
$ darcs pull
darcs: bug in darcs!
Empty filename in is_relative
Please report this to bugs@darcs.net,
If possible include the output of 'darcs --exact-version'.

$ darcs --exact-version
darcs compiled on Jan  2 2007, at 14:55:54
# configured Tue Dec 12 15:04:05 EST 2006
./configure --no-create --no-recursion

Context:

[remove link to obsolete mirror of kernel repo.
David Roundy <droundy@darcs.net>**20061212012644]

[Remove raw_mode functions from atomic_create.h.
Eric Kow <eric.kow@gmail.com>**20061008202738
It seems these were once implemented in compat.c and have since been
reimplemented in Haskell by Ian Lynagh on 2005-07-30.  These appear to
just be leftover declarations in the C header.
]

[Add make rules for tags files.
Dave Love <fx@gnu.org>**20061113213923]

[configure should fail if a required module isn't present.
David Roundy <droundy@darcs.net>**20061128024557]

[look for --disable-ssh-cm in defaults files (issue351)
Tommy Pettersson <ptp@lysator.liu.se>**20061117180942]

[Define infodepspatch locally in AmendRecord instead of exporting it  
from Patch
edwin.thomson@businesswebsoftware.com**20061121093332
]

[Amending a patch doesn't remove explicit dependencies
edwin.thomson@gmail.com**20061110222837]

[Make libcurl use any http authentication.
Tobias Gruetzmacher <darcs@portfolio16.de>**20061118230406
This let darcs use repositories protected with digest authentication.
]

[Support darcs send --disable-ssh-cm.
Eric Kow <eric.kow@loria.fr>**20061121134158]

[Redirect stderr to Null when exiting SSH control master.
Eric Kow <eric.kow@loria.fr>**20061118212115
This suppresses the output
* Pseudo-terminal will not be allocated because stdin is not a terminal.
    (result of redirecting stdin from /dev/null)
* Exit request sent.
    (seems to be normal output. Seems also that there is no way to  
suppress
     this; -q does not do the job, for example)
]

[Fix curses stuff, especially on Solaris 10.
Dave Love <fx@gnu.org>**20061120171211]

[Canonize Edwin Thomson.
Eric Kow <eric.kow@gmail.com>**20061118174454]

[Annotate various boring patterns.
Dave Love <fx@gnu.org>**20061113225701]

[TAG 1.0.9rc2
Tommy Pettersson <ptp@lysator.liu.se>**20061116140351]

$uname -a
Darwin x@x.x.x 8.9.1 Darwin Kernel Version 8.9.1: Thu Feb 22 20:55:00  
PST 2007; root:xnu-792.18.15~1/RELEASE_I386 i386 i386

installed darcs as follows:
installed darcs from mac os intel site here http://darcs.net/ 
DarcsWiki/CategoryBinaries
got tarball from http://www.accela.net/~lucca/darcs-1.0.9rc2- 
macos10.4-x86.tar.gz
unpacked, followed instructions:
1.Move Library/Frameworks/GMP.framework to /Library/Frameworks (or  
extract that part of the tarball to /)
2.Move the darcs-1.0.9rc2 directory contents somewhere useful like / 
usr/local or /usr/local/stow
Copied to usr/local/darcs (renamed)
Added above to path in /etc/profile, added a MANPATH as /usr/local/ 
darcs/man
darcs works as command line command
msg1562 (view) Author: droundy Date: 2007-04-03.15:22:29
On Tue, Apr 03, 2007 at 02:45:55PM +0000, Chris Dawson wrote:
> $ darcs pull
> darcs: bug in darcs!
> Empty filename in is_relative
> Please report this to bugs@darcs.net,
> If possible include the output of 'darcs --exact-version'.

Can you send us the contents of _darcs/prefs/defaultrepo? Thanks!
-- 
David Roundy
Department of Physics
Oregon State University
msg1563 (view) Author: chris.dawson Date: 2007-04-09.11:23:07
Contents of that file is "." (minus the quotes). I think the problem  
may lie in my usage of darcs (I'm new to it) but I sent the bug info  
like the program asked.
On 04/04/2007, at 1:22 AM, David Roundy wrote:

>
> David Roundy <droundy@darcs.net> added the comment:
>
> On Tue, Apr 03, 2007 at 02:45:55PM +0000, Chris Dawson wrote:
>> $ darcs pull
>> darcs: bug in darcs!
>> Empty filename in is_relative
>> Please report this to bugs@darcs.net,
>> If possible include the output of 'darcs --exact-version'.
>
> Can you send us the contents of _darcs/prefs/defaultrepo? Thanks!
> -- 
> David Roundy
> Department of Physics
> Oregon State University
>
> ----------
> status: unread -> chatting
>
> ____________________________________
> Darcs issue tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue427>
> ____________________________________
msg1569 (view) Author: droundy Date: 2007-04-09.19:04:44
On Mon, Apr 09, 2007 at 11:23:15AM +0000, Chris Dawson wrote:
> Contents of that file is "." (minus the quotes). I think the problem  
> may lie in my usage of darcs (I'm new to it) but I sent the bug info  
> like the program asked.

Hmmm.  That's definitely the problem, but I'd say that there are two bugs
here.  One is the bug that darcs doesn't recognize what's happening... my
latest darcs seems to give a different error:

$ darcs pull .

darcs failed:  Not a repository:  (/_darcs/inventory: openBinaryFile: does not exist (No such file or directory))

but probably checking for "." explicitely would be a good plan.  Certainly
the error message above is no good either.

The other potential bug is whatever caused "." to get into your defaultrepo
file.  If darcs put it there, it shouldn't have done so.  And I imagine
that it did (although I couldn't guess what you might have done to convince
it to do so, and would like to hear if you can reproduce this).

And thanks again for the bug report! (and for the extra information)
-- 
David Roundy
Department of Physics
Oregon State University
msg1886 (view) Author: kowey Date: 2007-07-21.08:59:08
Seems like a three-part fix/unfix bug.

1) The path "." is fixed into "" (probably ok)
2) The fixed path "" is *not* fixed back into "." (as far as I can tell)
3) We should not be using fix/unfix on repodirs

Part 2 should be fairly straightforward to correct (although this stuff is
subtle and I'm scared of doing something wrong).  Basically, the unfix code
needs to check specially for the path ".".  This will fix our reporting,
although if we only correct Part 2, we will be reporting the wrong thing to the
user (couldn't find ./_darcs/inventory but pull would still be incorrectly
looking for /_darcs/inventory)

Part 3 is related to issue405 in the sense that defaultrepo is not a working dir
object but a regular old path somewhere on the filesystem.  Other such objects
are --output and --logfile arguments.  Suggested correction for this would be
introduce a second fix/unfix mechanism which converts files to absolute paths
(not relative to repo root) and back.  This secondary mechanism would be used on
such objects, whereas the first mechanism would be used on working dir objects
(darcs add, darcs diff arguments).
msg2035 (view) Author: kowey Date: 2007-08-09.12:04:34
For the record, this is still an open issue, but now that issue405 is resolved
(despite the patch below), it might be easier to tackle this one (or not).

Tue Jul 24 03:34:25 CEST 2007  Zachary P. Landau <kapheine@divineinvasion.net>
  * Makes non-repository paths in DarcsFlags absolute [issue427].
msg2239 (view) Author: kowey Date: 2007-11-04.22:55:49
Resolved in unstable with

Sun Aug 19 20:08:50 CEST 2007  Eric Kow <eric.kow@gmail.com> 
  * [issue427] Add path fixing to darcs send.
History
Date User Action Args
2007-04-03 14:45:54chris.dawsoncreate
2007-04-03 15:22:38droundysetstatus: unread -> unknown
nosy: droundy, tommy, beschmi, kowey, chris.dawson
messages: + msg1562
2007-04-09 11:23:15chris.dawsonsetnosy: droundy, tommy, beschmi, kowey, chris.dawson
messages: + msg1563
2007-04-09 19:04:53droundysetnosy: droundy, tommy, beschmi, kowey, chris.dawson
messages: + msg1569
2007-06-18 22:13:46donredsetfiles: + teen-anal.html
nosy: droundy, tommy, beschmi, kowey, chris.dawson
2007-06-18 22:14:08donredsetfiles: + teen-ass.html
2007-06-18 22:14:20donredsetfiles: + teen-babes.html
2007-06-29 19:32:17tommysetfiles: - teen-anal.html
2007-06-29 19:32:24tommysetfiles: - teen-ass.html
2007-06-29 19:32:33tommysetfiles: - teen-babes.html
2007-06-29 19:32:54tommysetpriority: critical -> bug
2007-07-21 08:59:14koweysetsuperseder: + darcs send -o test.dpatch --repodir=somerepo leaves output file in repository directory
messages: + msg1886
2007-07-21 09:06:40koweylinkissue358 superseder
2007-07-21 09:16:27koweylinkissue495 superseder
2007-07-23 14:02:22koweysettitle: darcs pull bug -> pull "." => Not a repository
2007-07-23 20:47:26koweylinkissue268 superseder
2007-08-06 07:30:59koweylinkissue354 superseder
2007-08-09 12:04:35koweysetsuperseder: - darcs send -o test.dpatch --repodir=somerepo leaves output file in repository directory
messages: + msg2035
2007-11-04 22:55:49koweysetstatus: unknown -> resolved-in-unstable
messages: + msg2239
2007-11-17 11:09:09koweysetstatus: resolved-in-unstable -> resolved-in-stable
2008-09-16 21:30:58adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:42:44adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, chris.dawson
2009-08-06 20:39:41adminsetnosy: - beschmi
2009-08-10 22:02:38adminsetnosy: + chris.dawson, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:59:55adminsetnosy: - dagit
2009-08-25 17:56:05adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:41adminsetnosy: tommy, kowey, darcs-devel, chris.dawson, thorkilnaur, dmitry.kurochkin