Created on 2008-05-01.23:30:57 by lele, last changed 2009-08-27.14:09:53 by admin.
msg4441 (view) |
Author: lele |
Date: 2008-05-01.23:30:55 |
|
On my copy of darcs 2.0 repository:
$ darcs query repo
Type: darcs
Format: hashed, darcs-2
Root: /home/lele/wip/darcs-2.0
Pristine: HashedPristine
Cache: thisrepo:/home/lele/wip/darcs-2.0, repo:http://darcs.net
predist Pref: autoconf && ./configure --disable-optimize && ${MAKE-make} predist
test Pref: autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j2 test_unit check test_network
Default Remote: http://darcs.net
Num Patches: 5626
the "changes -i" does not seem to work properly: it loops over the
second patch, and never reaches the third:
$ darcs changes -i
Thu May 1 13:32:07 CEST 2008 David Roundy <droundy@darcs.net>
* reorder test suite around fact that test_unit takes so long.
Shall I view this patch? (1/5626) [yNvpxqkj], or ? for help: y
[reorder test suite around fact that test_unit takes so long.
David Roundy <droundy@darcs.net>**20080501113207] changepref test
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j8 check test_network test_unit
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j2 test_unit check test_network
Shall I view this patch? (1/5626) [yNvpxqkj], or ? for help: y
[reorder test suite around fact that test_unit takes so long.
David Roundy <droundy@darcs.net>**20080501113207] changepref test
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j8 check test_network test_unit
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j2 test_unit check test_network
Shall I view this patch? (1/5626) [yNvpxqkj], or ? for help: y
[reorder test suite around fact that test_unit takes so long.
David Roundy <droundy@darcs.net>**20080501113207] changepref test
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j8 check test_network test_unit
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j2 test_unit check test_network
Shall I view this patch? (1/5626) [yNvpxqkj], or ? for help: y
[reorder test suite around fact that test_unit takes so long.
David Roundy <droundy@darcs.net>**20080501113207] changepref test
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j8 check test_network test_unit
autoconf && ./configure --with-type-witnesses && make -j4 witnesses && make clean && ./configure && make -j 4 all unit && make -j2 test_unit check test_network
Shall I view this patch? (1/5626) [yNvpxqkj], or ? for help: q
Maybe something to do with the second patch being a setpref? And, by
the way, why does it immediately show the "content" of that patch,
without being asked for (with 'v')?
thank you,
ciao, lele.
--
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@nautilus.homeip.net | -- Fortunato Depero, 1929.
|
msg4448 (view) |
Author: kowey |
Date: 2008-05-02.08:55:35 |
|
Hi Lele,
I think this is not a bug, but an unexpected change in behaviour. Sorry!
Here is the patch that made the change
Mon Apr 21 11:52:47 BST 2008 Eric Kow <E.Y.Kow@brighton.ac.uk>
* resolve issue795: Make 'darcs changes -i' behave more like other jobs.
Old behaviour:
Shall I continue to view changes?
y - do not view this patch; keep going [DEFAULT]
n - quit
v - view this patch; keep going
q - quit
New behaviour:
Shall I view this patch?
y - view this patch; keep going
n - do not view this patch; keep going [DEFAULT]
v - view this patch; keep going
q - quit
|
msg4449 (view) |
Author: kowey |
Date: 2008-05-02.08:57:04 |
|
Oh wait, you're right. It does not 'keep going' as promised. Will submit a patch
|
msg4455 (view) |
Author: lele |
Date: 2008-05-02.09:20:28 |
|
On Fri, 02 May 2008 08:55:39 -0000
Eric Kow <bugs@darcs.net> wrote:
> I think this is not a bug, but an unexpected change in behaviour.
> Sorry! Here is the patch that made the change
>
> Mon Apr 21 11:52:47 BST 2008 Eric Kow <E.Y.Kow@brighton.ac.uk>
> * resolve issue795: Make 'darcs changes -i' behave more like other
> jobs.
> Old behaviour:
> Shall I continue to view changes?
> y - do not view this patch; keep going [DEFAULT]
> n - quit
> v - view this patch; keep going
> q - quit
>
> New behaviour:
> Shall I view this patch?
> y - view this patch; keep going
> n - do not view this patch; keep going [DEFAULT]
> v - view this patch; keep going
> q - quit
Ok, so both 'y' and 'v' show the current patch. But I still see a
minor problem, because the help says:
Shall I view this patch? (4/655) [yNvpxqkj], or ? for help: h
How to use view changes:
y: skip to the next patch
n: quit view changes
but 'y' does the same as 'v' but does *not* present the next patch,
and 'n' does *not* quit but instead does effectively show the next
patch:
$ darcs --version
2.0.0 (2.0.0 (+ 73 patches))
$ darcs changes -i
Fri May 2 10:41:18 CEST 2008 lele@nautilus.homeip.net
* Correct how darcs treats identical changes under darcs-2 format
Shall I view this patch? (1/5628) [yNvpxqkj], or ? for help: y
[Correct how darcs treats identical changes under darcs-2 format
lele@nautilus.homeip.net**20080502084118] hunk ./src/best_practices.tex 317
-darcs does considers two patches making the \emph{same} change to be a
+darcs does \emph{not} consider two patches making the \emph{same} change to be a
Shall I view this patch? (1/5628) [yNvpxqkj], or ? for help: y
[Correct how darcs treats identical changes under darcs-2 format
lele@nautilus.homeip.net**20080502084118] hunk ./src/best_practices.tex 317
-darcs does considers two patches making the \emph{same} change to be a
+darcs does \emph{not} consider two patches making the \emph{same} change to be a
Shall I view this patch? (1/5628) [yNvpxqkj], or ? for help: v
[Correct how darcs treats identical changes under darcs-2 format
lele@nautilus.homeip.net**20080502084118] hunk ./src/best_practices.tex 317
-darcs does considers two patches making the \emph{same} change to be a
+darcs does \emph{not} consider two patches making the \emph{same} change to be a
Shall I view this patch? (1/5628) [yNvpxqkj], or ? for help: n
Fri May 2 01:36:29 CEST 2008 lele@nautilus.homeip.net
* Added test for issue 803
Shall I view this patch? (2/5628) [yNvpxqkj], or ? for help: n
Thu May 1 13:32:07 CEST 2008 David Roundy <droundy@darcs.net>
* reorder test suite around fact that test_unit takes so long.
Shall I view this patch? (3/5628) [yNvpxqkj], or ? for help: q
You see, I hit 'y' twice and 'v' once, and get the same output, while
hitting 'n' I get the next patch.
The help message definitely needs some tweak, wrt 'y' and 'n'. Having
two choices that do the same thing is a little confusing (I mean, 'y'
and 'v'), but that's minor, once the help says the truth :-)
Thank you,
bye, lele.
--
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@nautilus.homeip.net | -- Fortunato Depero, 1929.
|
msg4481 (view) |
Author: E.Y.Kow |
Date: 2008-05-02.16:16:51 |
|
The following patch updated the status of issue827 to be resolved in the unstable branch:
* resolve issue827: correct changes -i behaviour
Promised old behaviour:
Shall I view this patch?
y - view this patch; keep going
n - do not view this patch; keep going [DEFAULT]
v - view this patch; keep going
q - quit
Actual old behaviour:
Shall I view this patch?
y - view this patch; stay put
n - do not view this patch; keep going [DEFAULT]
v - view this patch; stay put
q - quit
New behaviour:
Shall I view this patch?
y - view this patch; keep going
n - do not view this patch; keep going [DEFAULT]
v - view this patch; stay put
q - quit
You can view the patch details online here:
http://darcs.net/cgi-bin/darcs.cgi/unstable/?c=annotate&p=20080502090907-2067a-f7d2aa0f226edb616939ccf1698e93228b7645f4.gz
|
|
Date |
User |
Action |
Args |
2008-05-01 23:30:57 | lele | create | |
2008-05-02 08:55:39 | kowey | set | status: unread -> resolved priority: bug nosy:
+ kowey messages:
+ msg4448 topic:
+ FauxBug superseder:
+ Make 'darcs changes -i' behave more like other jobs. |
2008-05-02 08:57:05 | kowey | set | status: resolved -> unknown nosy:
tommy, beschmi, kowey, dagit, lele topic:
- FauxBug messages:
+ msg4449 assignedto: kowey |
2008-05-02 08:57:36 | kowey | set | nosy:
tommy, beschmi, kowey, dagit, lele title: changes -i" does not work properly on darcs 2.0 own repo -> changes -i loops on 'y' |
2008-05-02 09:20:30 | lele | set | nosy:
tommy, beschmi, kowey, dagit, lele messages:
+ msg4455 title: changes -i loops on 'y' -> changes -i" does not work properly on darcs 2.0 own repo |
2008-05-02 16:16:59 | E.Y.Kow | set | status: unknown -> resolved-in-unstable nosy:
+ E.Y.Kow messages:
+ msg4481 title: changes -i" does not work properly on darcs 2.0 own repo -> correct changes -i behaviour |
2008-09-04 21:33:23 | admin | set | status: resolved-in-unstable -> resolved nosy:
tommy, beschmi, kowey, dagit, lele, E.Y.Kow |
2009-08-06 18:23:07 | admin | set | nosy:
+ dmitry.kurochkin, simon, thorkilnaur, - lele, E.Y.Kow |
2009-08-06 21:03:46 | admin | set | nosy:
- beschmi |
2009-08-10 22:20:09 | admin | set | nosy:
+ E.Y.Kow, lele |
2009-08-11 00:12:21 | admin | set | nosy:
- dagit |
2009-08-25 18:09:21 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:09:53 | admin | set | nosy:
tommy, kowey, darcs-devel, lele, thorkilnaur, dmitry.kurochkin, E.Y.Kow |
|